Changeset 12869 in webkit


Ignore:
Timestamp:
Feb 17, 2006 1:37:34 AM (18 years ago)
Author:
adele
Message:

LayoutTests:

Reviewed by Maciej.

  • fast/css/universal-hover-quirk-expected.checksum: Added.
  • fast/css/universal-hover-quirk-expected.png: Added.
  • fast/css/universal-hover-quirk-expected.txt: Added.
  • fast/css/universal-hover-quirk.html: Added.

WebCore:

Test: fast/css/universal-hover-quirk.html

Reviewed by Maciej.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active from matching anything in quirks mode.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r12868 r12869  
     12006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
     2
     3        Reviewed by Maciej.
     4
     5        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
     6          Text underlined on mouse over
     7
     8        * fast/css/universal-hover-quirk-expected.checksum: Added.
     9        * fast/css/universal-hover-quirk-expected.png: Added.
     10        * fast/css/universal-hover-quirk-expected.txt: Added.
     11        * fast/css/universal-hover-quirk.html: Added.
     12
    1132006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
    214

  • trunk/WebCore/ChangeLog

    r12868 r12869  
     12006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
     2
     3        Test: fast/css/universal-hover-quirk.html
     4
     5        Reviewed by Maciej.
     6
     7        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
     8          Text underlined on mouse over
     9
     10        * css/cssstyleselector.cpp:
     11        (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active
     12        from matching anything in quirks mode.
     13
    1142006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
    215

  • trunk/WebCore/css/cssstyleselector.cpp

    r12865 r12869  
    14041404            case CSSSelector::PseudoHover: {
    14051405                // If we're in quirks mode, then hover should never match anchors with no
    1406                 // href.  This is important for sites like wsj.com.
    1407                 if (strictParsing || !e->hasTagName(aTag) || e->isLink()) {
     1406                // href and *:hover should not match anything.  This is important for sites like wsj.com.
     1407                if (strictParsing || (sel->hasTag() && !e->hasTagName(aTag)) || e->isLink()) {
    14081408                    if (element == e && style)
    14091409                        style->setAffectedByHoverRules(true);
    … …  
    14351435            case CSSSelector::PseudoActive:
    14361436                // If we're in quirks mode, then :active should never match anchors with no
    1437                 // href.
    1438                 if (strictParsing || !e->hasTagName(aTag) || e->isLink()) {
     1437                // href and *:active should not match anything.
     1438                if (strictParsing || (sel->hasTag() && !e->hasTagName(aTag)) || e->isLink()) {
    14391439                    if (element == e && style)
    14401440                        style->setAffectedByActiveRules(true);
Note: See TracChangeset for help on using the changeset viewer.