Changeset 128756 in webkit

Timestamp:

Sep 17, 2012 8:00:42 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
​https://bugs.webkit.org/show_bug.cgi?id=96077

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-09-17
Reviewed by Rob Buis.

Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
render message to record one time of page's update.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):

• Api/BackingStore_p.h:
• WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::render):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/BackingStore.cpp (modified) (2 diffs)
• Api/BackingStore_p.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• WebKitSupport/RenderQueue.cpp (modified) (2 diffs)

trunk/Source/WebKit/blackberry/Api/BackingStore.cpp

@@ -29 +29 @@
 #include "GraphicsContext.h"
 #include "InspectorController.h"
+#include "InspectorInstrumentation.h"
 #include "Page.h"
 #include "SurfacePool.h"
@@ -234 +235 @@
 
     pthread_mutex_destroy(&m_mutex);
+}
+
+void BackingStorePrivate::instrumentBeginFrame()
+{
+    WebCore::InspectorInstrumentation::didBeginFrame(WebPagePrivate::core(m_webPage));
+}
+
+void BackingStorePrivate::instrumentCancelFrame()
+{
+    WebCore::InspectorInstrumentation::didCancelFrame(WebPagePrivate::core(m_webPage));
 }
 

trunk/Source/WebKit/blackberry/Api/BackingStore_p.h

@@ -102 +102 @@
     BackingStorePrivate();
 
+    void instrumentBeginFrame();
+    void instrumentCancelFrame();
+
     // Returns whether direct rendering is explicitly turned on or is
     // required because the surface pool is not large enough to meet

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-09-17  Peter Wang  <peter.wang@torchmobile.com.cn>
+
+        [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=96077
+
+        Reviewed by Rob Buis.
+
+        Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
+        render message to record one time of page's update.
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
+        (WebKit):
+        (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
+        * Api/BackingStore_p.h:
+        * WebKitSupport/RenderQueue.cpp:
+        (BlackBerry::WebKit::RenderQueue::render):
+
 2012-09-17  Jakob Petsovits  <jpetsovits@rim.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp

@@ -565 +565 @@
 #endif
 
+    m_parent->instrumentBeginFrame();
+
     m_parent->requestLayoutIfNeeded();
 
@@ -585 +587 @@
     } else if (!m_nonVisibleScrollJobs.empty())
         renderNonVisibleScrollJob();
+
+    m_parent->instrumentCancelFrame();
 }