Changeset 128828 in webkit

Timestamp:

Sep 17, 2012 5:35:35 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Add rendering commit statistics
​https://bugs.webkit.org/show_bug.cgi?id=96938

Patch by Brian Anderson <​brianderson@chromium.org> on 2012-09-17
Reviewed by James Robinson.

Adds total commit time and total commit count to WebRenderingStats.
Allows us to caculate average commit time in performance tests.

Source/Platform:

• chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):
(WebKit::WebRenderingStats::enumerateFields):

Source/WebKit/chromium:

• src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::renderingStats):

Location:

trunk/Source

Files:

• Platform/ChangeLog (modified) (1 diff)
• Platform/chromium/public/WebRenderingStats.h (modified) (3 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/WebLayerTreeViewImpl.cpp (modified) (1 diff)

trunk/Source/Platform/ChangeLog

@@ +1 @@
+2012-09-17  Brian Anderson  <brianderson@chromium.org>
+
+        [chromium] Add rendering commit statistics
+        https://bugs.webkit.org/show_bug.cgi?id=96938
+
+        Reviewed by James Robinson.
+
+        Adds total commit time and total commit count to WebRenderingStats.
+        Allows us to caculate average commit time in performance tests.
+
+        * chromium/public/WebRenderingStats.h:
+        (WebRenderingStats):
+        (WebKit::WebRenderingStats::WebRenderingStats):
+        (WebKit::WebRenderingStats::enumerateFields):
+
 2012-09-17  Antoine Labour  <piman@chromium.org>
 

trunk/Source/Platform/chromium/public/WebRenderingStats.h

@@ -35 +35 @@
     double totalPaintTimeInSeconds;
     double totalRasterizeTimeInSeconds;
+    double totalCommitTimeInSeconds;
+    size_t totalCommitCount;
 
     WebRenderingStats()
@@ -42 +44 @@
         , totalPaintTimeInSeconds(0)
         , totalRasterizeTimeInSeconds(0)
+        , totalCommitTimeInSeconds(0)
+        , totalCommitCount(0)
     {
     }
@@ -65 +69 @@
         enumerator->addDouble("totalPaintTimeInSeconds", totalPaintTimeInSeconds);
         enumerator->addDouble("totalRasterizeTimeInSeconds", totalRasterizeTimeInSeconds);
+        enumerator->addDouble("totalCommitTimeInSeconds", totalCommitTimeInSeconds);
+        enumerator->addInt("totalCommitCount", totalCommitCount);
     }
 };

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-09-17  Brian Anderson  <brianderson@chromium.org>
+
+        [chromium] Add rendering commit statistics
+        https://bugs.webkit.org/show_bug.cgi?id=96938
+
+        Reviewed by James Robinson.
+
+        Adds total commit time and total commit count to WebRenderingStats.
+        Allows us to caculate average commit time in performance tests.
+
+        * src/WebLayerTreeViewImpl.cpp:
+        (WebKit::WebLayerTreeViewImpl::renderingStats):
+
 2012-09-17  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebLayerTreeViewImpl.cpp

@@ -196 +196 @@
     stats.totalPaintTimeInSeconds = ccStats.totalPaintTimeInSeconds;
     stats.totalRasterizeTimeInSeconds = ccStats.totalRasterizeTimeInSeconds;
+    stats.totalCommitTimeInSeconds = ccStats.totalCommitTimeInSeconds;
+    stats.totalCommitCount = ccStats.totalCommitCount;
 }