Changeset 128895 in webkit


Ignore:
Timestamp:
Sep 18, 2012 8:00:45 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
https://bugs.webkit.org/show_bug.cgi?id=97014

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
be used for literals rather than WTF::StringBuilder::append().

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::booleanForKey):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r128890 r128895  
     12012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
     2
     3        [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
     4        https://bugs.webkit.org/show_bug.cgi?id=97014
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
     9        be used for literals rather than WTF::StringBuilder::append().
     10
     11        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
     12        (WTR::InjectedBundle::booleanForKey):
     13
    1142012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
    215
  • trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp

    r128623 r128895  
    210210    WKTypeRef value = WKDictionaryGetItemForKey(dictionary, wkKey.get());
    211211    if (WKGetTypeID(value) != WKBooleanGetTypeID()) {
    212         stringBuilder()->append("Boolean value for key \"");
     212        stringBuilder()->appendLiteral("Boolean value for key \"");
    213213        stringBuilder()->append(key);
    214         stringBuilder()->append("\" not found in dictionary\n");
     214        stringBuilder()->appendLiteral("\" not found in dictionary\n");
    215215        return false;
    216216    }
Note: See TracChangeset for help on using the changeset viewer.