Changeset 128996 in webkit

Timestamp:

Sep 19, 2012 7:00:50 AM (12 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
​https://bugs.webkit.org/show_bug.cgi?id=97092

Reviewed by Martin Robinson.

Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.

• platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RedirectedXCompositeWindow.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] REGRESSION(r128907): it broke several WebKit2 API tests
+        https://bugs.webkit.org/show_bug.cgi?id=97092
+
+        Reviewed by Martin Robinson.
+
+        Calling resizeLater() from the constructor of
+        RedirectedXCompositeWindow can cause the callback to be called
+        later by the main loop after the RedirectedXCompositeWindow object
+        has been destroyed. Instead of calling resizeLater(), initialize
+        the usable size to the given initial size.
+
+        * platform/gtk/RedirectedXCompositeWindow.cpp:
+        (WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
+
 2012-09-19  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp

@@ -45 +45 @@
 
 RedirectedXCompositeWindow::RedirectedXCompositeWindow(const IntSize& size)
-    : m_window(0)
+    : m_usableSize(size)
+    , m_window(0)
     , m_parentWindow(0)
     , m_pixmap(0)
@@ -92 +93 @@
 
     resize(size);
-    resizeLater(); // Force update of the usable area.
 }