Changeset 129084 in webkit

Timestamp:

Sep 19, 2012 7:05:05 PM (12 years ago)

Author:

jason.liu@torchmobile.com.cn

Message:

[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
​https://bugs.webkit.org/show_bug.cgi?id=96994

Reviewed by Rob Buis.

We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.

No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/blackberry/NetworkJob.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-19  Jason Liu  <jason.liu@torchmobile.com.cn>
+
+        [BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
+        https://bugs.webkit.org/show_bug.cgi?id=96994
+
+        Reviewed by Rob Buis.
+
+        We should remove the wrong credentials before calling sendRequestWithCredentials again.
+        #PR 200226
+        Reviewed internally by Jonathan Dong.
+
+        No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.
+
+
+        * platform/network/blackberry/NetworkJob.cpp:
+        (WebCore::NetworkJob::notifyAuthReceived):
+
 2012-09-19  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp

@@ -295 +295 @@
         storeCredentials();
         return;
-    } else if (serverType != ProtectionSpaceProxyHTTP)
-        // If a wifi proxy auth failed, there is no point of trying anymore because the credentials are wrong.
+    } else {
+        purgeCredentials();
         m_newJobWithCredentialsStarted = sendRequestWithCredentials(serverType, scheme, realm, requireCredentials);
+    }
 }