Changeset 129106 in webkit

Timestamp:

Sep 20, 2012 1:35:20 AM (12 years ago)

Author:

keishi@webkit.org

Message:

REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=97166

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug in r127727 so arrow keys work properly.

Test: fast/forms/date/calendar-picker-key-operations.html

• Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):

LayoutTests:

• fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
• fast/forms/date/calendar-picker-key-operations.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/date/calendar-picker-key-operations-expected.txt (added)
• LayoutTests/fast/forms/date/calendar-picker-key-operations.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Resources/pagepopups/calendarPicker.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-20  Keishi Hattori  <keishi@webkit.org>
+
+        REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
+        https://bugs.webkit.org/show_bug.cgi?id=97166
+
+        Reviewed by Kent Tamura.
+
+        * fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
+        * fast/forms/date/calendar-picker-key-operations.html: Added.
+
 2012-09-20  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-20  Keishi Hattori  <keishi@webkit.org>
+
+        REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
+        https://bugs.webkit.org/show_bug.cgi?id=97166
+
+        Reviewed by Kent Tamura.
+
+        Fixing bug in r127727 so arrow keys work properly.
+
+        Test: fast/forms/date/calendar-picker-key-operations.html
+
+        * Resources/pagepopups/calendarPicker.js:
+        (DaysTable.prototype._maybeSetPreviousMonth):
+        (DaysTable.prototype._maybeSetNextMonth):
+
 2012-09-18  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js

@@ -986 +986 @@
  */
 DaysTable.prototype._maybeSetPreviousMonth = function() {
-    var year = global.yearMonthController.year();
-    var month = global.yearMonthController.month();
+    var year = this.picker.yearMonthController.year();
+    var month = this.picker.yearMonthController.month();
     var thisMonthStartTime = createUTCDate(year, month, 1).getTime();
-    if (this.minimumDate.getTime() >= thisMonthStartTime)
+    if (this.picker.minimumDate.getTime() >= thisMonthStartTime)
         return false;
     if (month == 0) {
@@ -1004 +1004 @@
  */
 DaysTable.prototype._maybeSetNextMonth = function() {
-    var year = global.yearMonthController.year();
-    var month = global.yearMonthController.month();
+    var year = this.picker.yearMonthController.year();
+    var month = this.picker.yearMonthController.month();
     if (month == 11) {
         year++;