Changeset 129191 in webkit

Timestamp:

Sep 20, 2012 9:44:21 PM (12 years ago)

Author:

yosin@chromium.org

Message:

[Platform] There are memory leak in LocaleICU
​https://bugs.webkit.org/show_bug.cgi?id=97289

Reviewed by Kent Tamura.

This patch adds udt_close() calls for medium time format and short
time format data used in LocaleICU class to avoid memory leak.

This memory leak is found by external tool Valgrind and reported in
Chromium bug repositry(​http://crbug.com/151006) with stack trace of
call path of leaked memory.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. External tool such as Valgrind will check this memory leak.

• platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
and m_shortTimeFormat which have UDateFormat objects.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/LocaleICU.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-20  Yoshifumi Inoue  <yosin@chromium.org>
+
+        [Platform] There are memory leak in LocaleICU
+        https://bugs.webkit.org/show_bug.cgi?id=97289
+
+        Reviewed by Kent Tamura.
+
+        This patch adds udt_close() calls for medium time format and short
+        time format data used in LocaleICU class to avoid memory leak.
+
+        This memory leak is found by external tool Valgrind and reported in
+        Chromium bug repositry(http://crbug.com/151006) with stack trace of
+        call path of leaked memory.
+
+        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
+        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
+
+        No new tests. External tool such as Valgrind will check this memory leak.
+
+        * platform/text/LocaleICU.cpp:
+        (WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
+        and m_shortTimeFormat which have UDateFormat objects.
+
 2012-09-20  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/Source/WebCore/platform/text/LocaleICU.cpp

@@ -69 +69 @@
     unum_close(m_numberFormat);
     udat_close(m_shortDateFormat);
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
+    udat_close(m_mediumTimeFormat);
+    udat_close(m_shortTimeFormat);
+#endif
 }