Changeset 129330 in webkit
- Timestamp:
- Sep 24, 2012 12:41:04 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r129317 r129330 1 2012-09-24 Matt Falkenhagen <falken@chromium.org> 2 3 Skeleton implementation of dialog.showModal() 4 https://bugs.webkit.org/show_bug.cgi?id=97425 5 6 Reviewed by Kent Tamura. 7 8 Add a test that showModal() opens the dialog or throws an error in the cases specified in the spec. 9 10 * fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt: Added. 11 * fast/dom/HTMLDialogElement/dialog-show-modal.html: Added. 12 1 13 2012-09-23 Gavin Barraclough <barraclough@apple.com> 2 14 -
trunk/Source/WebCore/ChangeLog
r129329 r129330 1 2012-09-24 Matt Falkenhagen <falken@chromium.org> 2 3 Skeleton implementation of dialog.showModal() 4 https://bugs.webkit.org/show_bug.cgi?id=97425 5 6 Reviewed by Kent Tamura. 7 8 This adds a basic implementation of showModal(), so it later can be 9 used to test the top layer, once it is implemented. The main features 10 of showModal(), modality and the top layer, are not yet implemented. 11 12 Test: fast/dom/HTMLDialogElement/dialog-show-modal.html 13 14 * html/HTMLDialogElement.cpp: 15 (WebCore::HTMLDialogElement::showModal): The same as show(), but throws an error in the cases specified in the spec. 16 (WebCore): 17 * html/HTMLDialogElement.h: 18 (HTMLDialogElement): 19 * html/HTMLDialogElement.idl: 20 1 21 2012-09-24 Ryuan Choi <ryuan.choi@samsung.com> 2 22 -
trunk/Source/WebCore/html/HTMLDialogElement.cpp
r127681 r129330 63 63 } 64 64 65 void HTMLDialogElement::showModal(ExceptionCode& ec) 66 { 67 if (fastHasAttribute(openAttr) || !inDocument()) { 68 ec = INVALID_STATE_ERR; 69 return; 70 } 71 setBooleanAttribute(openAttr, true); 72 } 73 65 74 bool HTMLDialogElement::isPresentationAttribute(const QualifiedName& name) const 66 75 { -
trunk/Source/WebCore/html/HTMLDialogElement.h
r127681 r129330 42 42 void close(ExceptionCode&); 43 43 void show(); 44 void showModal(ExceptionCode&); 44 45 45 46 private: -
trunk/Source/WebCore/html/HTMLDialogElement.idl
r123193 r129330 32 32 void close() raises(DOMException); 33 33 void show(); 34 void showModal() raises(DOMException); 34 35 }; 35 36
Note: See TracChangeset
for help on using the changeset viewer.