Changeset 129455 in webkit


Ignore:
Timestamp:
Sep 24, 2012 9:40:48 PM (12 years ago)
Author:
yosin@chromium.org
Message:

[Forms] We should remove DateTimeEditElement::valueAsDouble()
​https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
  • html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.

(DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
  • html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.

(DateTimeFieldElement):

  • html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
  • html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r129452 r129455  
     12012-09-24  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        [Forms] We should remove DateTimeEditElement::valueAsDouble()
     4        https://bugs.webkit.org/show_bug.cgi?id=97327
     5
     6        Reviewed by Kent Tamura.
     7
     8        This patch removes unused function DateTimeEditElement::valueAsDouble()
     9        and related functions in DateTimeFieldElement.
     10
     11        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
     12        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
     13
     14        No new tests. This patch doesn't change behavior.
     15
     16        * html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
     17        * html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.
     18        (DateTimeEditElement):
     19        * html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
     20        * html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.
     21        (DateTimeFieldElement):
     22        * html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
     23        * html/shadow/DateTimeFieldElements.h:
     24        (DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
     25        (DateTimeHourFieldElement): ditto.
     26        (DateTimeMillisecondFieldElement): ditto.
     27        (DateTimeMinuteFieldElement): ditto.
     28        (DateTimeSecondFieldElement): ditto.
     29
    1302012-09-24  Antti Koivisto  <antti@apple.com>
    231

  • trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp

    r129441 r129455  
    466466}
    467467
    468 double DateTimeEditElement::valueAsDouble() const
    469 {
    470     double value = 0;
    471 
    472     for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex) {
    473         const DateTimeFieldElement* const field = m_fields[fieldIndex];
    474         if (!field->hasValue())
    475             return std::numeric_limits<double>::quiet_NaN();
    476         value += field->valueAsDouble();
    477     }
    478 
    479     return value;
    480 }
    481 
    482468} // namespace WebCore
    483469

  • trunk/Source/WebCore/html/shadow/DateTimeEditElement.h

    r129441 r129455  
    9292    String value() const;
    9393    DateTimeFieldsState valueAsDateTimeFieldsState() const;
    94     double valueAsDouble() const;
    9594
    9695private:

  • trunk/Source/WebCore/html/shadow/DateTimeFieldElement.cpp

    r128404 r129455  
    187187}
    188188
    189 double DateTimeFieldElement::valueAsDouble() const
    190 {
    191     return hasValue() ? valueAsInteger() * unitInMillisecond() : std::numeric_limits<double>::quiet_NaN();
    192 }
    193 
    194189} // namespace WebCore
    195190

  • trunk/Source/WebCore/html/shadow/DateTimeFieldElement.h

    r128575 r129455  
    7171    virtual void stepUp() = 0;
    7272    virtual String value() const = 0;
    73     double valueAsDouble() const;
    7473    virtual int valueAsInteger() const = 0;
    7574    virtual String visibleValue() const = 0;
    … …  
    8483    virtual int maximum() const = 0;
    8584    virtual int minimum() const = 0;
    86     virtual double unitInMillisecond() const = 0;
    8785    void updateVisibleValue(EventBehavior);
    8886

  • trunk/Source/WebCore/html/shadow/DateTimeFieldElements.cpp

    r128575 r129455  
    3131#include "DateTimeFieldsState.h"
    3232#include "LocalizedStrings.h"
    33 #include <wtf/DateMath.h>
    3433
    3534namespace WebCore {
    … …  
    6766    else
    6867        setEmptyValue(dateForReadOnlyField);
    69 }
    70 
    71 double DateTimeAMPMFieldElement::unitInMillisecond() const
    72 {
    73     return msPerHour * 12;
    7468}
    7569
    … …  
    174168}
    175169
    176 double DateTimeHourFieldElement::unitInMillisecond() const
    177 {
    178     return msPerHour;
    179 }
    180 
    181170int DateTimeHourFieldElement::valueAsInteger() const
    182171{
    … …  
    225214}
    226215
    227 double DateTimeMillisecondFieldElement::unitInMillisecond() const
    228 {
    229     return 1;
    230 }
    231 
    232216// ----------------------------
    233217
    … …  
    271255}
    272256
    273 double DateTimeMinuteFieldElement::unitInMillisecond() const
    274 {
    275     return msPerMinute;
    276 }
    277 
    278257// ----------------------------
    279258
    … …  
    317296}
    318297
    319 double DateTimeSecondFieldElement::unitInMillisecond() const
    320 {
    321     return msPerSecond;
    322 }
    323 
    324298} // namespace WebCore
    325299

  • trunk/Source/WebCore/html/shadow/DateTimeFieldElements.h

    r128575 r129455  
    4646    virtual void setValueAsDate(const DateComponents&) OVERRIDE FINAL;
    4747    virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&, const DateComponents& dateForReadOnlyField) OVERRIDE FINAL;
    48     virtual double unitInMillisecond() const OVERRIDE FINAL;
    4948};
    5049
    … …  
    7069    virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&, const DateComponents& dateForReadOnlyField) OVERRIDE FINAL;
    7170    virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) OVERRIDE FINAL;
    72     virtual double unitInMillisecond() const OVERRIDE FINAL;
    7371    virtual int valueAsInteger() const OVERRIDE FINAL;
    7472
    … …  
    8987    virtual void setValueAsDate(const DateComponents&) OVERRIDE FINAL;
    9088    virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&, const DateComponents& dateForReadOnlyField) OVERRIDE FINAL;
    91     virtual double unitInMillisecond() const OVERRIDE FINAL;
    9289};
    9390
    … …  
    105102    virtual void setValueAsDate(const DateComponents&) OVERRIDE FINAL;
    106103    virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&, const DateComponents& dateForReadOnlyField) OVERRIDE FINAL;
    107     virtual double unitInMillisecond() const OVERRIDE FINAL;
    108104};
    109105
    … …  
    121117    virtual void setValueAsDate(const DateComponents&) OVERRIDE FINAL;
    122118    virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&, const DateComponents& dateForReadOnlyField) OVERRIDE FINAL;
    123     virtual double unitInMillisecond() const OVERRIDE FINAL;
    124119};
    125120
Note: See TracChangeset for help on using the changeset viewer.