Changeset 129604 in webkit


Ignore:
Timestamp:
Sep 26, 2012 12:38:12 AM (12 years ago)
Author:
zandobersek@gmail.com
Message:

[GTK] Enable some of the unstable CSS features
​https://bugs.webkit.org/show_bug.cgi?id=97572

Reviewed by Martin Robinson.

.:

Export the required RuntimeEnabledFeatures symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

Enable the CSS sticky position, CSS3 text decoration and <style scoped>
features by default but disable them if unstable features are not meant
to be enabled.

No new tests - the related tests are being unskipped or are having failure
expectations removed.

  • GNUmakefile.am:
  • GNUmakefile.features.am:

Source/WebKit/gtk:

Add a helper DumpRenderTreeSupportGtk method for enabling
the <style scoped> support in WebCore. This is used in DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
ENABLE(SHADOW_DOM) compilation guards.
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
no information and is causing style warnings.

Tools:

Enable the <style scoped> support via DumpRenderTreeSupportGtk method
whenever resetting defualts to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

Remove expectations for the features being enabled and
add more specific failure expectations for tests that are
still failing.

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r129560 r129604  
     12012-09-26  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] Enable some of the unstable CSS features
     4        https://bugs.webkit.org/show_bug.cgi?id=97572
     5
     6        Reviewed by Martin Robinson.
     7
     8        Export the required RuntimeEnabledFeatures symbol.
     9
     10        * Source/autotools/symbols.filter:
     11
    1122012-09-25  Cosmin Truta  <ctruta@rim.com>
    213

  • trunk/LayoutTests/ChangeLog

    r129601 r129604  
     12012-09-26  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] Enable some of the unstable CSS features
     4        https://bugs.webkit.org/show_bug.cgi?id=97572
     5
     6        Reviewed by Martin Robinson.
     7
     8        Remove expectations for the features being enabled and
     9        add more specific failure expectations for tests that are
     10        still failing.
     11
     12        * platform/gtk/TestExpectations:
     13
    1142012-09-26  Gavin Barraclough  <barraclough@apple.com>
    215

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r129520 r129604  
    300300Bug(GTK) http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html [ Skip ]
    301301
    302 # <style scoped> is not yet enabled.
    303 webkit.org/b/49142 fast/css/style-scoped [ Failure ]
    304 
    305 # CSS Regions tests for region styling and scoped styles
    306 Bug(GTK) fast/regions/style-scoped-in-flow-override-container-style.html [ ImageOnlyFailure ]
    307 Bug(GTK) fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html [ ImageOnlyFailure ]
    308 Bug(GTK) fast/regions/style-scoped-in-flow-override-region-styling.html [ ImageOnlyFailure ]
    309 Bug(GTK) fast/regions/style-scoped-in-flow.html [ ImageOnlyFailure ]
    310 
    311302# CSS Filters is disabled
    312303Bug(GTK) css3/filters [ Skip ]
    … …  
    319310Bug(GTK) fast/css/image-set-parsing-invalid.html [ Skip ]
    320311Bug(GTK) fast/css/image-set-setting.html [ Skip ]
    321 
    322 # CSS Sticky Position is not yet enabled
    323 Bug(GTK) fast/css/sticky [ Skip ]
    324312
    325313# For now, Web Audio API is disabled
    … …  
    402390# CSS image-orientation is not yet enabled.
    403391webkit.org/b/89052 fast/css/image-orientation
    404 
    405 # CSS3 Text Decoration support is not yet enabled (needs ENABLE_CSS3_TEXT_DECORATION).
    406 webkit.org/b/58491 fast/css3-text-decoration
    407392
    408393# No CORS support for media elements is implemented yet.
    … …  
    12111196
    12121197webkit.org/b/84701 fast/block/line-layout/selection-highlight-overlap.html [ ImageOnlyFailure ]
     1198webkit.org/b/84701 fast/css/sticky/inline-sticky-abspos-child.html [ ImageOnlyFailure ]
     1199webkit.org/b/84701 fast/css/sticky/inline-sticky.html [ ImageOnlyFailure ]
    12131200
    12141201webkit.org/b/85376 fullscreen/video-controls-drag.html [ Failure ]
    … …  
    13051292webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
    13061293
    1307 # Failing after r123379 on EFL and GTK.
    1308 webkit.org/b/92063 fast/css/sticky/parsing-position-sticky.html [ Failure ]
    1309 
    13101294webkit.org/b/92100 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
    13111295
    … …  
    13721356webkit.org/b/97529 http/tests/security/xss-eval.html [ Failure ]
    13731357
     1358webkit.org/b/49142 fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html [ ImageOnlyFailure ]
     1359
    13741360#////////////////////////////////////////////////////////////////////////////////////////
    13751361# End of Tests failing

  • trunk/Source/WebCore/ChangeLog

    r129602 r129604  
     12012-09-26  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] Enable some of the unstable CSS features
     4        https://bugs.webkit.org/show_bug.cgi?id=97572
     5
     6        Reviewed by Martin Robinson.
     7
     8        Enable the CSS sticky position, CSS3 text decoration and <style scoped>
     9        features by default but disable them if unstable features are not meant
     10        to be enabled.
     11
     12        No new tests - the related tests are being unskipped or are having failure
     13        expectations removed.
     14
     15        * GNUmakefile.am:
     16        * GNUmakefile.features.am:
     17
    1182012-09-26  Dongwoo Joshua Im  <dw.im@samsung.com>
    219

  • trunk/Source/WebCore/GNUmakefile.am

    r128992 r129604  
    349349if !ENABLE_UNSTABLE_FEATURES
    350350feature_defines_unstable += \
     351        ENABLE_CSS3_TEXT_DECORATION=0 \
     352        ENABLE_CSS_STICKY_POSITION=0 \
     353        ENABLE_LINK_PREFETCH=0 \
    351354        ENABLE_MUTATION_OBSERVERS=0 \
    352         ENABLE_LINK_PREFETCH=0 \
     355        ENABLE_STYLE_SCOPED=0 \
    353356        ENABLE_VIDEO_TRACK=0 \
    354357        ENABLE_WEB_TIMING=0

  • trunk/Source/WebCore/GNUmakefile.features.am

    r129260 r129604  
    77        ENABLE_CHANNEL_MESSAGING=1 \
    88        ENABLE_CSP_NEXT=0 \
     9        ENABLE_CSS3_TEXT_DECORATION=1 \
    910        ENABLE_CSS_BOX_DECORATION_BREAK=1 \
    1011        ENABLE_CSS_COMPOSITING=0 \
    … …  
    1617        ENABLE_CSS_REGIONS=1 \
    1718        ENABLE_CSS_SHADERS=0 \
     19        ENABLE_CSS_STICKY_POSITION=1 \
    1820        ENABLE_CSS_VARIABLES=0 \
    1921        ENABLE_CUSTOM_SCHEME_HANDLER=0 \
    … …  
    7779        ENABLE_SPELLCHECK=1 \
    7880        ENABLE_SQL_DATABASE=1 \
    79         ENABLE_STYLE_SCOPED=0 \
     81        ENABLE_STYLE_SCOPED=1 \
    8082        ENABLE_SVG=1 \
    8183        ENABLE_SVG_DOM_OBJC_BINDINGS=0 \

  • trunk/Source/WebKit/gtk/ChangeLog

    r129545 r129604  
     12012-09-26  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] Enable some of the unstable CSS features
     4        https://bugs.webkit.org/show_bug.cgi?id=97572
     5
     6        Reviewed by Martin Robinson.
     7
     8        Add a helper DumpRenderTreeSupportGtk method for enabling
     9        the <style scoped> support in WebCore. This is used in DumpRenderTree.
     10
     11        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
     12        (DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
     13        ENABLE(SHADOW_DOM) compilation guards.
     14        (DumpRenderTreeSupportGtk::setStyleScopedEnabled):
     15        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
     16        (DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
     17        setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
     18        no information and is causing style warnings.
     19
    1202012-09-25  Beth Dakin  <bdakin@apple.com>
    221

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

    r129444 r129604  
    694694void DumpRenderTreeSupportGtk::setShadowDOMEnabled(bool enabled)
    695695{
     696#if ENABLE(SHADOW_DOM)
    696697    RuntimeEnabledFeatures::setShadowDOMEnabled(enabled);
     698#endif
     699}
     700
     701void DumpRenderTreeSupportGtk::setStyleScopedEnabled(bool enabled)
     702{
     703#if ENABLE(STYLE_SCOPED)
     704    RuntimeEnabledFeatures::setStyleScopedEnabled(enabled);
     705#endif
    697706}
    698707

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

    r129444 r129604  
    119119    static void setCSSGridLayoutEnabled(WebKitWebView*, bool enabled);
    120120    static void setCSSRegionsEnabled(WebKitWebView*, bool enabled);
    121     static void setShadowDOMEnabled(bool enabled);
     121    static void setShadowDOMEnabled(bool);
     122    static void setStyleScopedEnabled(bool);
    122123
    123124    static void deliverAllMutationsIfNecessary();

  • trunk/Source/autotools/symbols.filter

    r129462 r129604  
    185185_ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE;
    186186_ZN7WebCore22RuntimeEnabledFeatures37isAuthorShadowDOMForAnyElementEnabledE;
     187_ZN7WebCore22RuntimeEnabledFeatures20isStyleScopedEnabledE;
    187188_ZNK7WebCore8Document13nodesFromRectEiijjjjbb;
    188189_ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_8NodeListE;

  • trunk/Tools/ChangeLog

    r129600 r129604  
     12012-09-26  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] Enable some of the unstable CSS features
     4        https://bugs.webkit.org/show_bug.cgi?id=97572
     5
     6        Reviewed by Martin Robinson.
     7
     8        Enable the <style scoped> support via DumpRenderTreeSupportGtk method
     9        whenever resetting defualts to consistent values.
     10
     11        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     12        (resetDefaultsToConsistentValues):
     13
    1142012-09-26  Zan Dobersek  <zandobersek@gmail.com>
    215

  • trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r129595 r129604  
    518518    DumpRenderTreeSupportGtk::setCSSRegionsEnabled(webView, true);
    519519    DumpRenderTreeSupportGtk::setShadowDOMEnabled(true);
     520    DumpRenderTreeSupportGtk::setStyleScopedEnabled(true);
    520521}
    521522
Note: See TracChangeset for help on using the changeset viewer.