Changeset 130716 in webkit

Timestamp:

Oct 8, 2012 7:18:20 PM (12 years ago)

Author:

tkent@chromium.org

Message:

Take account of overflowing values for width calculation of a year sub-field
​https://bugs.webkit.org/show_bug.cgi?id=98506

Reviewed by Eric Seidel.

Source/WebCore:

When we decide the width of a year field of an input[type=date]
with the multiple fields UI, we need to take account of the
current value width because we allow to set overflowing values to
the input[type=date].

This change affects only platforms with INPUT_TYPE_DATE &&
INPUT_MULTIPLE_FIELDS_UI.

Test: fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html

• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Take account of the current value width.

LayoutTests:

• fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Added.
• fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt (added)
• LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-10-08  Kent Tamura  <tkent@chromium.org>
+
+        Take account of overflowing values for width calculation of a year sub-field
+        https://bugs.webkit.org/show_bug.cgi?id=98506
+
+        Reviewed by Eric Seidel.
+
+        * fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Added.
+        * fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Added.
+
 2012-10-08  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-08  Kent Tamura  <tkent@chromium.org>
+
+        Take account of overflowing values for width calculation of a year sub-field
+        https://bugs.webkit.org/show_bug.cgi?id=98506
+
+        Reviewed by Eric Seidel.
+
+        When we decide the width of a year field of an input[type=date]
+        with the multiple fields UI, we need to take account of the
+        current value width because we allow to set overflowing values to
+        the input[type=date].
+
+        This change affects only platforms with INPUT_TYPE_DATE &&
+        INPUT_MULTIPLE_FIELDS_UI.
+
+        Test: fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html
+
+        * html/shadow/DateTimeNumericFieldElement.cpp:
+        (WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
+        Take account of the current value width.
+
 2012-10-08  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp

@@ -82 +82 @@
     float maxiumWidth = style->font().width(m_placeholder);
     maxiumWidth = std::max(maxiumWidth, style->font().width(formatValue(maximum())));
+    maxiumWidth = std::max(maxiumWidth, style->font().width(value()));
     style->setWidth(Length(maxiumWidth, Fixed));
     return style.release();