Changeset 133657 in webkit

Timestamp:

Nov 6, 2012 12:25:52 PM (11 years ago)

Author:

abarth@webkit.org

Message:

DOMImplementation should use ScriptWrappable
​https://bugs.webkit.org/show_bug.cgi?id=101279

Reviewed by Eric Seidel.

PerformanceTests:

This simple PerformanceTest measure how quickly we can access
document.implementation. The goal of this performance test is just to
validate that using ScriptWrappable actually makes the bindings faster.

• Bindings/document-implementation.html: Added.

Source/WebCore:

This patch makes DOMImplementation ScriptWrappable. Both the V8 and JSC
bindings automatically detect the presence of this base class and use
it to optimize getting and setting JavaScript wrappers.

This patch is a 23% progression on Bindings/document-implementation for
the V8 bindings and a 69% progression for the JSC bindings.

• dom/DOMImplementation.h:

Location:

trunk

Files:

• PerformanceTests/Bindings/document-implementation.html (added)
• PerformanceTests/ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/DOMImplementation.h (modified) (1 diff)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2012-11-06  Adam Barth  <abarth@webkit.org>
+
+        DOMImplementation should use ScriptWrappable
+        https://bugs.webkit.org/show_bug.cgi?id=101279
+
+        Reviewed by Eric Seidel.
+
+        This simple PerformanceTest measure how quickly we can access
+        document.implementation. The goal of this performance test is just to
+        validate that using ScriptWrappable actually makes the bindings faster.
+
+        * Bindings/document-implementation.html: Added.
+
 2012-11-05  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-06  Adam Barth  <abarth@webkit.org>
+
+        DOMImplementation should use ScriptWrappable
+        https://bugs.webkit.org/show_bug.cgi?id=101279
+
+        Reviewed by Eric Seidel.
+
+        This patch makes DOMImplementation ScriptWrappable. Both the V8 and JSC
+        bindings automatically detect the presence of this base class and use
+        it to optimize getting and setting JavaScript wrappers.
+
+        This patch is a 23% progression on Bindings/document-implementation for
+        the V8 bindings and a 69% progression for the JSC bindings.
+
+        * dom/DOMImplementation.h:
+
 2012-11-06  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/dom/DOMImplementation.h

@@ -43 +43 @@
 typedef int ExceptionCode;
 
-class DOMImplementation {
+class DOMImplementation : public ScriptWrappable {
     WTF_MAKE_FAST_ALLOCATED;
 public: