Changeset 133952 in webkit

Timestamp:

Nov 8, 2012 2:25:28 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Update BB10 date input form.
​https://bugs.webkit.org/show_bug.cgi?id=101075

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2012-11-08
Reviewed by Rob Buis.

RIM PR 234531
Internally Reviewed by Mike Fenton.
Change date input appearance to button and hide caret when click on them.

Source/WebCore:

• css/themeBlackBerry.css:

(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):

Source/WebKit/blackberry:

• WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValueAndClosePopup):

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/themeBlackBerry.css (modified) (2 diffs)
• WebKit/blackberry/ChangeLog (modified) (1 diff)
• WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp (modified) (2 diffs)
• WebKit/blackberry/WebKitSupport/InputHandler.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-08  Tiancheng Jiang  <tijiang@rim.com>
+
+        [BlackBerry] Update BB10 date input form.
+        https://bugs.webkit.org/show_bug.cgi?id=101075
+
+        Reviewed by Rob Buis.
+
+        RIM PR 234531
+        Internally Reviewed by Mike Fenton.
+        Change date input appearance to button and hide caret when click on them.
+
+        * css/themeBlackBerry.css:
+        (input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):
+
 2012-11-08  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/css/themeBlackBerry.css

@@ -19 +19 @@
 textarea {
     font-family: monospace;
-}
-
-input[type="datetime"],
-input[type="date"],
-input[type="week"],
-input[type="month"],
-input[type="time"],
-input[type="datetime-local"],
-input[type="number"],
-input[type="color"] {
-    border: solid 2px blue;
 }
 
@@ -64 +53 @@
     font-weight: normal;
 }
+
+input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"] {
+    -webkit-appearance: button;
+    text-align: center;
+}

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-11-08  Tiancheng Jiang  <tijiang@rim.com>
+
+        [BlackBerry] Update BB10 date input form.
+        https://bugs.webkit.org/show_bug.cgi?id=101075
+
+        Reviewed by Rob Buis.
+
+        RIM PR 234531
+        Internally Reviewed by Mike Fenton.
+        Change date input appearance to button and hide caret when click on them.
+
+        * WebCoreSupport/DatePickerClient.cpp:
+        (WebCore::DatePickerClient::setValueAndClosePopup):
+        * WebKitSupport/InputHandler.cpp:
+        (BlackBerry::WebKit::InputHandler::openDatePopup):
+
 2012-11-08  Nima Ghanavatian  <nghanavatian@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp

@@ -24 +24 @@
 #include "Document.h"
 #include "DocumentWriter.h"
+#include "Frame.h"
 #include "HTMLInputElement.h"
 #include "Page.h"
@@ -129 +130 @@
     ASSERT(m_element);
 
+    // We hide caret when we select date input field, restore it when we close date picker.
+    m_element->document()->frame()->selection()->setCaretVisible(true);
+
     if (value != "-1")
         m_element->setValue(value);

trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

@@ -983 +983 @@
     case BlackBerry::Platform::InputTypeDateTimeLocal:
     case BlackBerry::Platform::InputTypeMonth: {
+        // Date input have button appearance, we hide caret when they get clicked.
+        element->document()->frame()->selection()->setCaretVisible(false);
+
         // Check if popup already exists, close it if does.
         m_webPage->m_page->chrome()->client()->closePagePopup(0);