Changeset 134659 in webkit


Ignore:
Timestamp:
Nov 14, 2012 1:27:51 PM (11 years ago)
Author:
arv@chromium.org
Message:

Update DOMException name: InUseAttributeError
​https://bugs.webkit.org/show_bug.cgi?id=102141

Reviewed by Ojan Vafai.

Patch 10 of 25 to update DOMException name to match the spec and Firefox.

The name for this is not in the spec but the case was selected to match
Firefox. ​http://mxr.mozilla.org/mozilla-central/source/dom/base/domerr.msg#18

INUSE_ATTRIBUTE_ERR is historical and not used in any spec or any of our tests.

  • dom/DOMCoreException.cpp:
  • dom/ExceptionCode.h:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/fast/dom/move-nodes-across-documents.html

    r134655 r134659  
    157157        document.body.attributes.setNamedItem(attribute);
    158158        iframeDoc.body.attributes.setNamedItem(attribute);
    159     }, 'INUSE_ATTRIBUTE_ERR');
     159    }, 'InUseAttributeError');
    160160
    161161    runTest(function() {

  • trunk/Source/WebCore/ChangeLog

    r134657 r134659  
     12012-11-14  Erik Arvidsson  <arv@chromium.org>
     2
     3        Update DOMException name: InUseAttributeError
     4        https://bugs.webkit.org/show_bug.cgi?id=102141
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Patch 10 of 25 to update DOMException name to match the spec and Firefox.
     9
     10        The name for this is not in the spec but the case was selected to match
     11        Firefox. http://mxr.mozilla.org/mozilla-central/source/dom/base/domerr.msg#18
     12
     13        INUSE_ATTRIBUTE_ERR is historical and not used in any spec or any of our tests.
     14
     15        * dom/DOMCoreException.cpp:
     16        * dom/ExceptionCode.h:
     17
    1182012-11-14  Lynn Neir  <lynn.neir@skype.net>
    219

  • trunk/Source/WebCore/dom/DOMCoreException.cpp

    r134655 r134659  
    4545    { "NotFoundError", "An attempt was made to reference a Node in a context where it does not exist." },
    4646    { "NOT_SUPPORTED_ERR", "The implementation did not support the requested type of object or operation." },
    47     { "INUSE_ATTRIBUTE_ERR", "An attempt was made to add an attribute that is already in use elsewhere." },
     47    { "InUseAttributeError", "An attempt was made to add an attribute that is already in use elsewhere." },
    4848    { "InvalidStateError", "An attempt was made to use an object that is not, or is no longer, usable." },
    4949    { "SYNTAX_ERR", "An invalid or illegal string was specified." },

  • trunk/Source/WebCore/dom/ExceptionCode.h

    r134646 r134659  
    4444        NOT_FOUND_ERR = 8,
    4545        NOT_SUPPORTED_ERR = 9,
    46         INUSE_ATTRIBUTE_ERR = 10,
     46        INUSE_ATTRIBUTE_ERR = 10, // Historical
    4747
    4848        // Introduced in DOM Level 2:
Note: See TracChangeset for help on using the changeset viewer.