Changeset 136105 in webkit


Ignore:
Timestamp:
Nov 28, 2012 11:46:01 PM (11 years ago)
Author:
mkwst@chromium.org
Message:

Add a test to ensure that 'seamless' iframes do not inherit contenteditable.
https://bugs.webkit.org/show_bug.cgi?id=95890

Reviewed by Ojan Vafai.

Source/WebCore:

We don't currently support inheriting contenteditable into a seamless
frame. http://html5.org/tools/web-apps-tracker?from=7318&to=7319
brought the spec in line with WebKit's behavior (ha!). This patch
defends the behavior by adding a test, and removes a FIXME comment
now that the question is settled.

It also exposes a brand new bug: https://bugs.webkit.org/show_bug.cgi?id=103539
How exciting.

Test: fast/frames/seamless/seamless-contenteditable-not-inherited.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForDocument):

No functional change, just dropping a FIXME comment.

LayoutTests:

  • fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt: Added.
  • fast/frames/seamless/seamless-contenteditable-not-inherited.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r136104 r136105  
     12012-11-28  Mike West  <mkwst@chromium.org>
     2
     3        Add a test to ensure that 'seamless' iframes do not inherit contenteditable.
     4        https://bugs.webkit.org/show_bug.cgi?id=95890
     5
     6        Reviewed by Ojan Vafai.
     7
     8        * fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt: Added.
     9        * fast/frames/seamless/seamless-contenteditable-not-inherited.html: Added.
     10
    1112012-11-28  Mike West  <mkwst@chromium.org>
    212
  • trunk/Source/WebCore/ChangeLog

    r136104 r136105  
     12012-11-28  Mike West  <mkwst@chromium.org>
     2
     3        Add a test to ensure that 'seamless' iframes do not inherit contenteditable.
     4        https://bugs.webkit.org/show_bug.cgi?id=95890
     5
     6        Reviewed by Ojan Vafai.
     7
     8        We don't currently support inheriting contenteditable into a seamless
     9        frame. http://html5.org/tools/web-apps-tracker?from=7318&to=7319
     10        brought the spec in line with WebKit's behavior (ha!). This patch
     11        defends the behavior by adding a test, and removes a FIXME comment
     12        now that the question is settled.
     13
     14        It also exposes a brand new bug: https://bugs.webkit.org/show_bug.cgi?id=103539
     15        How exciting.
     16
     17        Test: fast/frames/seamless/seamless-contenteditable-not-inherited.html
     18
     19        * css/StyleResolver.cpp:
     20        (WebCore::StyleResolver::styleForDocument):
     21            No functional change, just dropping a FIXME comment.
     22
    1232012-11-28  Mike West  <mkwst@chromium.org>
    224
  • trunk/Source/WebCore/css/StyleResolver.cpp

    r136080 r136105  
    13991399        documentStyle->setLocale(document->contentLanguage());
    14001400    }
    1401     // FIXME: This overrides any -webkit-user-modify inherited from the parent iframe.
     1401    // This overrides any -webkit-user-modify inherited from the parent iframe.
    14021402    documentStyle->setUserModify(document->inDesignMode() ? READ_WRITE : READ_ONLY);
    14031403
Note: See TracChangeset for help on using the changeset viewer.