Changeset 136173 in webkit

Timestamp:

Nov 29, 2012 3:17:24 PM (11 years ago)

Author:

zhajiang@rim.com

Message:

[BlackBerry] window.open can load url twice which can cause security and timing issues
​https://bugs.webkit.org/show_bug.cgi?id=103670

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Yong Li.

PR: 252234
When we call window.open() in JS, DOMWindow will create a window and
change the url to load the resources. However, during the window
creation, we dispatch an OpenWindow event with the url to browser side
and browser side loads the url thereafter as well.
DOMWindow::createWindow() is only required to create the window not to
load url as far as I can tell. This is unneccessary and can cause
unexpected issues. So just pass an empty url instead to avoid
the double-load issue.

• WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-11-29  Jacky Jiang  <zhajiang@rim.com>
+
+        [BlackBerry] window.open can load url twice which can cause security and timing issues
+        https://bugs.webkit.org/show_bug.cgi?id=103670
+
+        Reviewed by Yong Li.
+
+        PR: 252234
+        When we call window.open() in JS, DOMWindow will create a window and
+        change the url to load the resources. However, during the window
+        creation, we dispatch an OpenWindow event with the url to browser side
+        and browser side loads the url thereafter as well.
+        DOMWindow::createWindow() is only required to create the window not to
+        load url as far as I can tell. This is unneccessary and can cause
+        unexpected issues. So just pass an empty url instead to avoid
+        the double-load issue.
+
+        * WebCoreSupport/ChromeClientBlackBerry.cpp:
+        (WebCore::ChromeClientBlackBerry::createWindow):
+
 2012-11-29  Otto Derek Cheung  <otcheung@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

@@ -258 +258 @@
         flags |= WebPageClient::FlagWindowIsDialog;
 
-    WebPage* webPage = m_webPagePrivate->m_client->createWindow(x, y, width, height, flags, url.string(), request.frameName());
+    WebPage* webPage = m_webPagePrivate->m_client->createWindow(x, y, width, height, flags, BlackBerry::Platform::String::emptyString(), request.frameName());
     if (!webPage)
         return 0;