Changeset 136913 in webkit


Ignore:
Timestamp:
Dec 6, 2012 5:48:46 PM (11 years ago)
Author:
dominicc@chromium.org
Message:

Element.pseudo property should be prefixed
​https://bugs.webkit.org/show_bug.cgi?id=104060

Reviewed by Hajime Morita.

Source/WebCore:

Other Shadow DOM properties are prefixed; pseudo should be too.

Covered by updated tests in fast/dom/shadow.

  • dom/Element.idl:

LayoutTests:

Updated tests.

  • fast/dom/shadow/pseudo-attribute-dynamic.html:
  • fast/dom/shadow/pseudo-attribute-expected.txt:
  • fast/dom/shadow/pseudo-attribute-rendering.html:
  • fast/dom/shadow/pseudo-attribute.html:
  • fast/dom/shadow/shadow-pseudo-id.html:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r136911 r136913  
     12012-12-06  Dominic Cooney  <dominicc@chromium.org>
     2
     3        Element.pseudo property should be prefixed
     4        https://bugs.webkit.org/show_bug.cgi?id=104060
     5
     6        Reviewed by Hajime Morita.
     7
     8        Updated tests.
     9
     10        * fast/dom/shadow/pseudo-attribute-dynamic.html:
     11        * fast/dom/shadow/pseudo-attribute-expected.txt:
     12        * fast/dom/shadow/pseudo-attribute-rendering.html:
     13        * fast/dom/shadow/pseudo-attribute.html:
     14        * fast/dom/shadow/shadow-pseudo-id.html:
     15
    1162012-12-06  Li Yin  <li.yin@intel.com>
    217

  • trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic.html

    r133769 r136913  
    2525var shadowRoot = new WebKitShadowRoot(host);
    2626var div = document.createElement('div');
    27 div.pseudo = 'x-foo';
     27div.webkitPseudo = 'x-foo';
    2828div.innerHTML = "This should be blue.";
    2929shadowRoot.appendChild(div);
    3030
    3131setTimeout(function() {
    32     div.pseudo = 'x-bar';
     32    div.webkitPseudo = 'x-bar';
    3333    if (window.testRunner)
    3434        testRunner.notifyDone();

  • trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-expected.txt

    r135236 r136913  
    11This test checks pseudo attribute is exposed correctly.
    22
    3 PASS div.pseudo is ''
     3PASS div.webkitPseudo is ''
    44PASS div.getAttribute('pseudo') is null
    5 PASS div.pseudo is 'foo'
     5PASS div.webkitPseudo is 'foo'
    66PASS div.getAttribute('pseudo') is 'foo'
    7 PASS div.pseudo is 'bar'
     7PASS div.webkitPseudo is 'bar'
    88PASS div.getAttribute('pseudo') is 'bar'
    9 PASS div.pseudo is ''
     9PASS div.webkitPseudo is ''
    1010PASS div.getAttribute('pseudo') is null
    11 PASS div.pseudo is 'first-letter'
     11PASS div.webkitPseudo is 'first-letter'
    1212PASS successfullyParsed is true
    1313

  • trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html

    r133715 r136913  
    2121var shadowRoot1 = new WebKitShadowRoot(host1);
    2222var div1 = document.createElement('div');
    23 div1.pseudo = 'x-foo';
     23div1.webkitPseudo = 'x-foo';
    2424div1.innerHTML = "This text should be red.";
    2525shadowRoot1.appendChild(div1);
    … …  
    2727var shadowRoot2 = new WebKitShadowRoot(host2);
    2828var div2 = document.createElement('div');
    29 div2.pseudo = '-webkit-foobar';
     29div2.webkitPseudo = '-webkit-foobar';
    3030div2.innerHTML = "This text should not be red.";
    3131shadowRoot2.appendChild(div2);

  • trunk/LayoutTests/fast/dom/shadow/pseudo-attribute.html

    r135236 r136913  
    1111var div = document.createElement('div');
    1212
    13 shouldBe("div.pseudo", "''");
     13shouldBe("div.webkitPseudo", "''");
    1414shouldBe("div.getAttribute('pseudo')", "null");
    1515
    1616div.setAttribute("pseudo", "foo");
    17 shouldBe("div.pseudo", "'foo'");
     17shouldBe("div.webkitPseudo", "'foo'");
    1818shouldBe("div.getAttribute('pseudo')", "'foo'");
    1919
    20 div.pseudo = "bar";
    21 shouldBe("div.pseudo", "'bar'");
     20div.webkitPseudo = "bar";
     21shouldBe("div.webkitPseudo", "'bar'");
    2222shouldBe("div.getAttribute('pseudo')", "'bar'");
    2323
    2424div.removeAttribute('pseudo');
    25 shouldBe("div.pseudo", "''");
     25shouldBe("div.webkitPseudo", "''");
    2626shouldBe("div.getAttribute('pseudo')", "null");
    2727
    2828// Checks pseudo accepts known pseudo-element word.
    29 div.pseudo = 'first-letter';
    30 shouldBe("div.pseudo", "'first-letter'");
     29div.webkitPseudo = 'first-letter';
     30shouldBe("div.webkitPseudo", "'first-letter'");
    3131
    3232finishJSTest();

  • trunk/LayoutTests/fast/dom/shadow/shadow-pseudo-id.html

    r133577 r136913  
    2929var div1 = document.createElement('div');
    3030div1.innerHTML = "pseudo is x-shadow: This should be red.";
    31 div1.pseudo = "x-shadow";
     31div1.webkitPseudo = "x-shadow";
    3232shadowRoot1.appendChild(div1);
    3333
    … …  
    3535var div2 = document.createElement('div');
    3636div2.innerHTML = "pseudo is -test: This should not be red.";
    37 div2.pseudo = "-test";
     37div2.webkitPseudo = "-test";
    3838shadowRoot2.appendChild(div2);
    3939
    … …  
    4141var div3 = document.createElement('div');
    4242div3.innerHTML = "pseudo is foobar: This should not be red.";
    43 div3.pseudo = "foobar";
     43div3.webkitPseudo = "foobar";
    4444shadowRoot3.appendChild(div3);
    4545</script>

  • trunk/Source/WebCore/ChangeLog

    r136908 r136913  
     12012-12-06  Dominic Cooney  <dominicc@chromium.org>
     2
     3        Element.pseudo property should be prefixed
     4        https://bugs.webkit.org/show_bug.cgi?id=104060
     5
     6        Reviewed by Hajime Morita.
     7
     8        Other Shadow DOM properties are prefixed; pseudo should be too.
     9
     10        Covered by updated tests in fast/dom/shadow.
     11
     12        * dom/Element.idl:
     13
    1142012-12-06  Andrei Bucur  <abucur@adobe.com>
    215

  • trunk/Source/WebCore/dom/Element.idl

    r136092 r136913  
    122122    // ShadowAware API
    123123#if defined(ENABLE_SHADOW_DOM) && ENABLE_SHADOW_DOM
    124     [Reflect, V8EnabledAtRuntime=shadowDOM] attribute DOMString pseudo;
     124    [Reflect=pseudo, V8EnabledAtRuntime=shadowDOM, ImplementedAs=pseudo] attribute DOMString webkitPseudo;
    125125    [V8EnabledAtRuntime=shadowDOM, ImplementedAs=createShadowRoot] ShadowRoot webkitCreateShadowRoot() raises(DOMException);
    126126#endif
Note: See TracChangeset for help on using the changeset viewer.