Changeset 137596 in webkit

Timestamp:

Dec 13, 2012 7:43:38 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Expose ARIA roles for tab, tabpanel and tablist
​https://bugs.webkit.org/show_bug.cgi?id=84043

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-13
Reviewed by Martin Robinson.

Source/WebCore:

Mapped the ARIA roles to their corresponding ATK roles.

No new tests; instead unskipped the associated test.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): Mapped the ARIA roles to their corresponding ATK roles

LayoutTests:

Mapped the ARIA roles to the corresponding ATK roles and unskipped the
associated test. Also created the missing platform-specific expected
results.

• accessibility/aria-tab-roles-expected.txt: Added.
• platform/gtk/TestExpectations: Unskipped the associated test.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/aria-tab-roles-expected.txt (added)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-12-13  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] Expose ARIA roles for tab, tabpanel and tablist
+        https://bugs.webkit.org/show_bug.cgi?id=84043
+
+        Reviewed by Martin Robinson.
+
+        Mapped the ARIA roles to the corresponding ATK roles and unskipped the
+        associated test. Also created the missing platform-specific expected
+        results.
+
+        * accessibility/aria-tab-roles-expected.txt: Added.
+        * platform/gtk/TestExpectations: Unskipped the associated test.
+
 2012-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -42 +42 @@
 #////////////////////////////////////////////////////////////////////////////////////////
 
-webkit.org/b/84043 accessibility/aria-tab-roles.html [ Missing ]
 webkit.org/b/84044 accessibility/image-link.html [ Missing ]
 webkit.org/b/84045 accessibility/image-map1.html [ Missing ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-13  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] Expose ARIA roles for tab, tabpanel and tablist
+        https://bugs.webkit.org/show_bug.cgi?id=84043
+
+        Reviewed by Martin Robinson.
+
+        Mapped the ARIA roles to their corresponding ATK roles.
+
+        No new tests; instead unskipped the associated test.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (atkRole): Mapped the ARIA roles to their corresponding ATK roles
+
 2012-12-13  Vivek Galatage  <vivek.vg@samsung.com>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

@@ -479 +479 @@
         return ATK_ROLE_SLIDER;
     case TabGroupRole:
+    case TabListRole:
         return ATK_ROLE_PAGE_TAB_LIST;
     case TextFieldRole:
@@ -532 +533 @@
     case GroupRole:
     case RadioGroupRole:
+    case TabPanelRole:
         return ATK_ROLE_PANEL;
     case RowHeaderRole: // Row headers are cells after all.
@@ -571 +573 @@
     case SpinButtonRole:
         return ATK_ROLE_SPIN_BUTTON;
+    case TabRole:
+        return ATK_ROLE_PAGE_TAB;
     default:
         return ATK_ROLE_UNKNOWN;