Changeset 138301 in webkit


Ignore:
Timestamp:
Dec 20, 2012 2:20:31 PM (11 years ago)
Author:
beidson@apple.com
Message:

[GTK] Remove the --enable-unstable-features configuration option
​https://bugs.webkit.org/show_bug.cgi?id=105327

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-12-20
Reviewed by Martin Robinson.

Remove the unnecessary feature_defines_unstable variable.
Remove the unstable-features configuration option.

  • configure.ac:
  • GNUmakefile.am:
Location:
trunk/Source/WebKit2
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r138273 r138301  
     12012-12-20  Brady Eidson  <beidson@apple.com>
     2
     3        NetworkProcess has no need for suspend/resumePendingRequests.
     4        <rdar://problem/12866005> and https://bugs.webkit.org/show_bug.cgi?id=105550
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        suspend/resumePendingRequests were important in a single-process, WebKit1 API world to help prevent
     9        client callbacks from occurring during layout/painting.
     10
     11        In a WebKit2 + NetworkProcess world, they aren't important.
     12
     13        Remove the Web->Network process messages:
     14        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
     15        * NetworkProcess/NetworkConnectionToWebProcess.h:
     16        * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
     17        * NetworkProcess/NetworkResourceLoadScheduler.cpp:
     18        * NetworkProcess/NetworkResourceLoadScheduler.h:
     19
     20        For now, still keep the per-WebProcess count to help keep servePendingRequest working as WebCore intends:
     21        * WebProcess/Network/WebResourceLoadScheduler.cpp:
     22        (WebKit::WebResourceLoadScheduler::servePendingRequests):
     23        (WebKit::WebResourceLoadScheduler::suspendPendingRequests):
     24        (WebKit::WebResourceLoadScheduler::resumePendingRequests):
     25
    1262012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
    227

  • trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp

    r138109 r138301  
    140140}
    141141
    142 void NetworkConnectionToWebProcess::suspendPendingRequests()
    143 {
    144     NetworkProcess::shared().networkResourceLoadScheduler().suspendPendingRequests();
    145 }
    146 
    147 void NetworkConnectionToWebProcess::resumePendingRequests()
    148 {
    149     NetworkProcess::shared().networkResourceLoadScheduler().resumePendingRequests();
    150 }
    151 
    152142void NetworkConnectionToWebProcess::setSerialLoadingEnabled(bool enabled)
    153143{

  • trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h

    r138109 r138301  
    8484    void crossOriginRedirectReceived(ResourceLoadIdentifier, const WebCore::KURL& redirectURL);
    8585    void servePendingRequests(uint32_t resourceLoadPriority);
    86     void suspendPendingRequests();
    87     void resumePendingRequests();
    8886    void setSerialLoadingEnabled(bool);
    8987    void startDownload(bool privateBrowsingEnabled, uint64_t downloadID, const WebCore::ResourceRequest&);

  • trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in

    r138109 r138301  
    3434   
    3535    ServePendingRequests(uint32_t resourceLoadPriority)
    36 
    37     SuspendPendingRequests() -> ()
    38     ResumePendingRequests() -> ()
    3936   
    4037    SetSerialLoadingEnabled(bool enabled) -> ()

  • trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp

    r137515 r138301  
    210210}
    211211
    212 void NetworkResourceLoadScheduler::suspendPendingRequests()
    213 {
    214     ++m_suspendPendingRequestsCount;
    215 }
    216 
    217 void NetworkResourceLoadScheduler::resumePendingRequests()
    218 {
    219     ASSERT(m_suspendPendingRequestsCount);
    220     --m_suspendPendingRequestsCount;
    221     if (m_suspendPendingRequestsCount)
    222         return;
    223 
    224     if (!m_hosts.isEmpty() || m_nonHTTPProtocolHost->hasRequests())
    225         scheduleServePendingRequests();
    226 }
    227 
    228212static bool removeScheduledLoadIdentifiersCalled = false;
    229213

  • trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h

    r135017 r138301  
    6262    void receivedRedirect(ResourceLoadIdentifier, const WebCore::KURL& redirectURL);
    6363    void servePendingRequests(WebCore::ResourceLoadPriority = WebCore::ResourceLoadPriorityVeryLow);
    64     void suspendPendingRequests();
    65     void resumePendingRequests();
    6664   
    6765    NetworkResourceLoader* networkResourceLoaderForIdentifier(ResourceLoadIdentifier);

  • trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp

    r137351 r138301  
    163163    LOG(NetworkScheduling, "(WebProcess) WebResourceLoadScheduler::servePendingRequests");
    164164   
    165     // If this WebProcess has its own request suspension count then we don't even
    166     // have to bother messaging the NetworkProcess.
     165    // The NetworkProcess scheduler is good at making sure loads are serviced until there are no more pending requests.
     166    // If this WebProcess isn't expecting requests to be served then we can ignore messaging the NetworkProcess right now.
    167167    if (m_suspendPendingRequestsCount)
    168168        return;
    … …  
    173173void WebResourceLoadScheduler::suspendPendingRequests()
    174174{
    175     WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::SuspendPendingRequests(), Messages::NetworkConnectionToWebProcess::SuspendPendingRequests::Reply(), 0);
    176 
    177175    ++m_suspendPendingRequestsCount;
    178176}
    … …  
    180178void WebResourceLoadScheduler::resumePendingRequests()
    181179{
    182     WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::ResumePendingRequests(), Messages::NetworkConnectionToWebProcess::ResumePendingRequests::Reply(), 0);
    183 
    184180    ASSERT(m_suspendPendingRequestsCount);
    185181    --m_suspendPendingRequestsCount;
Note: See TracChangeset for help on using the changeset viewer.