Changeset 138726 in webkit


Ignore:
Timestamp:
Jan 3, 2013 12:04:47 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Canvas blending tests fail on Mac WK2
​https://bugs.webkit.org/show_bug.cgi?id=105943

Patch by Rik Cabanier <​cabanier@adobe.com> on 2013-01-03
Reviewed by Simon Fraser.

Source/WebCore:

Tests that now pass:

LayoutTests/fast/canvas/canvas-blend-solid.html
LayoutTests/fast/canvas/canvas-blend-image.html

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):

Source/WebKit2:

CanvasUsesAcceleratedDrawing preference was not passed to the WebProcess.

  • WebProcess/InjectedBundle/InjectedBundle.cpp: Adds support for CanvasUsesAcceleratedDrawing to WK2

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

LayoutTests:

  • platform/mac-wk2/TestExpectations: updated expectations as the test now passes
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r138724 r138726  
     12013-01-03  Rik Cabanier  <cabanier@adobe.com>
     2
     3        Canvas blending tests fail on Mac WK2
     4        https://bugs.webkit.org/show_bug.cgi?id=105943
     5
     6        Reviewed by Simon Fraser.
     7
     8        * platform/mac-wk2/TestExpectations: updated expectations as the test now passes
     9
    1102013-01-03  Adam Klein  <adamk@chromium.org>
    211

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r138718 r138726  
    273273webkit.org/b/76359 fast/dom/shadow [ Skip ]
    274274
    275 # Canvas blending tests fail on Mac WK2
    276 webkit.org/b/105943 fast/canvas/canvas-blend-image.html [ Failure ]
    277 webkit.org/b/105943 fast/canvas/canvas-blend-solid.html [ Failure ]
    278 
    279275# fast/events/controlclick-no-onclick.html fails on Mac WK2
    280276webkit.org/b/105948 fast/events/controlclick-no-onclick.html [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r138725 r138726  
     12013-01-03  Rik Cabanier  <cabanier@adobe.com>
     2
     3        Canvas blending tests fail on Mac WK2
     4        https://bugs.webkit.org/show_bug.cgi?id=105943
     5
     6        Reviewed by Simon Fraser.
     7
     8        Tests that now pass:
     9            LayoutTests/fast/canvas/canvas-blend-solid.html
     10            LayoutTests/fast/canvas/canvas-blend-image.html
     11
     12        * testing/InternalSettings.cpp:
     13        (WebCore::InternalSettings::Backup::Backup):
     14        (WebCore::InternalSettings::Backup::restoreTo):
     15        * testing/InternalSettings.h:
     16        (Backup):
     17
    1182013-01-03   Arko Saha  <arko@motorola.com>
    219

  • trunk/Source/WebCore/testing/InternalSettings.cpp

    r138678 r138726  
    9696    , m_originalCompositingForScrollableFramesEnabled(settings->acceleratedCompositingForScrollableFramesEnabled())
    9797    , m_originalAcceleratedDrawingEnabled(settings->acceleratedDrawingEnabled())
     98    , m_originalCanvasUsesAcceleratedDrawing(settings->canvasUsesAcceleratedDrawing())
    9899    , m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
    99100    , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
    … …  
    142143    settings->setAcceleratedCompositingForScrollableFramesEnabled(m_originalCompositingForScrollableFramesEnabled);
    143144    settings->setAcceleratedDrawingEnabled(m_originalAcceleratedDrawingEnabled);
     145    settings->setCanvasUsesAcceleratedDrawing(m_originalCanvasUsesAcceleratedDrawing);
    144146    settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
    145147    RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);

  • trunk/Source/WebCore/testing/InternalSettings.h

    r138678 r138726  
    8383        bool m_originalCompositingForScrollableFramesEnabled;
    8484        bool m_originalAcceleratedDrawingEnabled;
     85        bool m_originalCanvasUsesAcceleratedDrawing;
    8586        bool m_originalMockScrollbarsEnabled;
    8687        bool m_originalUsesOverlayScrollbars;

  • trunk/Source/WebKit2/ChangeLog

    r138723 r138726  
     12013-01-03  Rik Cabanier  <cabanier@adobe.com>
     2
     3        Canvas blending tests fail on Mac WK2
     4        https://bugs.webkit.org/show_bug.cgi?id=105943
     5
     6        Reviewed by Simon Fraser.
     7
     8        CanvasUsesAcceleratedDrawing preference was not passed to the WebProcess.
     9
     10        * WebProcess/InjectedBundle/InjectedBundle.cpp: Adds support for CanvasUsesAcceleratedDrawing to WK2
     11        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
     12
    1132013-01-02  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
    214

  • trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

    r138520 r138726  
    202202#define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
    203203    macro(WebKitAcceleratedCompositingEnabled, AcceleratedCompositingEnabled, acceleratedCompositingEnabled) \
     204    macro(WebKitCanvasUsesAcceleratedDrawing, CanvasUsesAcceleratedDrawing, canvasUsesAcceleratedDrawing) \
    204205    macro(WebKitCSSCustomFilterEnabled, CSSCustomFilterEnabled, cssCustomFilterEnabled) \
    205206    macro(WebKitCSSGridLayoutEnabled, CSSGridLayoutEnabled, cssGridLayoutEnabled) \
Note: See TracChangeset for help on using the changeset viewer.