Changeset 138738 in webkit


Ignore:
Timestamp:
Jan 3, 2013 2:05:35 PM (11 years ago)
Author:
tommyw@google.com
Message:

MediaStream API: Add a missing state to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=106017

Reviewed by Adam Barth.

Adding the missing ReadyStateHaveRemoteOffer which will show up in the spec soon.

Source/Platform:

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

Source/WebCore:

Not testable, just another state.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::readyState):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/Platform/ChangeLog

    r138687 r138738  
     12013-01-03  Tommy Widenflycht  <tommyw@google.com>
     2
     3        MediaStream API: Add a missing state to RTCPeerConnection
     4        https://bugs.webkit.org/show_bug.cgi?id=106017
     5
     6        Reviewed by Adam Barth.
     7
     8        Adding the missing ReadyStateHaveRemoteOffer which will show up in the spec soon.
     9
     10        * chromium/public/WebRTCPeerConnectionHandlerClient.h:
     11
    1122013-01-02  James Robinson  <jamesr@chromium.org>
    213

  • trunk/Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h

    r137441 r138738  
    4242        ReadyStateNew = 1,
    4343        ReadyStateHaveLocalOffer = 2,
    44         ReadyStateHaveLocalPrAnswer = 3,
    45         ReadyStateHaveRemotePrAnswer = 4,
    46         ReadyStateActive = 5,
    47         ReadyStateClosed = 6,
     44        ReadyStateHaveRemoteOffer = 3,
     45        ReadyStateHaveLocalPrAnswer = 4,
     46        ReadyStateHaveRemotePrAnswer = 5,
     47        ReadyStateActive = 6,
     48        ReadyStateClosed = 7,
    4849
    4950        // DEPRECATED
    50         ReadyStateClosing = 7,
    51         ReadyStateOpening = 8
     51        ReadyStateClosing = 8,
     52        ReadyStateOpening = 9
    5253    };
    5354

  • trunk/Source/WebCore/ChangeLog

    r138736 r138738  
     12013-01-03  Tommy Widenflycht  <tommyw@google.com>
     2
     3        MediaStream API: Add a missing state to RTCPeerConnection
     4        https://bugs.webkit.org/show_bug.cgi?id=106017
     5
     6        Reviewed by Adam Barth.
     7
     8        Adding the missing ReadyStateHaveRemoteOffer which will show up in the spec soon.
     9
     10        Not testable, just another state.
     11
     12        * Modules/mediastream/RTCPeerConnection.cpp:
     13        (WebCore::RTCPeerConnection::readyState):
     14        * platform/mediastream/RTCPeerConnectionHandlerClient.h:
     15
    1162013-01-03  Emil A Eklund  <eae@chromium.org>
    217

  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

    r137441 r138738  
    314314    case ReadyStateHaveLocalOffer:
    315315        return ASCIILiteral("have-local-offer");
     316    case ReadyStateHaveRemoteOffer:
     317        return ASCIILiteral("have-remote-offer");
    316318    case ReadyStateHaveLocalPrAnswer:
    317319        return ASCIILiteral("have-local-pranswer");

  • trunk/Source/WebCore/platform/mediastream/RTCPeerConnectionHandlerClient.h

    r137441 r138738  
    4747        ReadyStateNew = 1,
    4848        ReadyStateHaveLocalOffer = 2,
    49         ReadyStateHaveLocalPrAnswer = 3,
    50         ReadyStateHaveRemotePrAnswer = 4,
    51         ReadyStateActive = 5,
    52         ReadyStateClosed = 6,
     49        ReadyStateHaveRemoteOffer = 3,
     50        ReadyStateHaveLocalPrAnswer = 4,
     51        ReadyStateHaveRemotePrAnswer = 5,
     52        ReadyStateActive = 6,
     53        ReadyStateClosed = 7,
    5354
    5455        // DEPRECATED
    55         ReadyStateClosing = 7,
    56         ReadyStateOpening = 8
     56        ReadyStateClosing = 8,
     57        ReadyStateOpening = 9
    5758    };
    5859

  • trunk/Source/WebKit/chromium/ChangeLog

    r138716 r138738  
     12013-01-03  Tommy Widenflycht  <tommyw@google.com>
     2
     3        MediaStream API: Add a missing state to RTCPeerConnection
     4        https://bugs.webkit.org/show_bug.cgi?id=106017
     5
     6        Reviewed by Adam Barth.
     7
     8        Adding the missing ReadyStateHaveRemoteOffer which will show up in the spec soon.
     9
     10        * src/AssertMatchingEnums.cpp:
     11
    1122013-01-03  Joshua Bell  <jsbell@chromium.org>
    213

  • trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp

    r138716 r138738  
    565565COMPILE_ASSERT_MATCHING_ENUM(WebRTCPeerConnectionHandlerClient::ReadyStateNew, RTCPeerConnectionHandlerClient::ReadyStateNew);
    566566COMPILE_ASSERT_MATCHING_ENUM(WebRTCPeerConnectionHandlerClient::ReadyStateHaveLocalOffer, RTCPeerConnectionHandlerClient::ReadyStateHaveLocalOffer);
     567COMPILE_ASSERT_MATCHING_ENUM(WebRTCPeerConnectionHandlerClient::ReadyStateHaveRemoteOffer, RTCPeerConnectionHandlerClient::ReadyStateHaveRemoteOffer);
    567568COMPILE_ASSERT_MATCHING_ENUM(WebRTCPeerConnectionHandlerClient::ReadyStateHaveLocalPrAnswer, RTCPeerConnectionHandlerClient::ReadyStateHaveLocalPrAnswer);
    568569COMPILE_ASSERT_MATCHING_ENUM(WebRTCPeerConnectionHandlerClient::ReadyStateHaveRemotePrAnswer, RTCPeerConnectionHandlerClient::ReadyStateHaveRemotePrAnswer);
Note: See TracChangeset for help on using the changeset viewer.