Changeset 138893 in webkit
- Timestamp:
- Jan 5, 2013 12:01:16 PM (11 years ago)
- Location:
- trunk/Source/WebKit/chromium
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/chromium/ChangeLog
r138859 r138893 1 2013-01-05 Chris Hopman <cjhopman@google.com> 2 3 Add function to move caret selection towards a point 4 https://bugs.webkit.org/show_bug.cgi?id=105189 5 6 Reviewed by Eric Seidel. 7 8 This function moves the selection to the corresponding point in the 9 rootEditableElement of the current selection. Used on Android for 10 the behavior of insertion handles (i.e. dragging the caret around). 11 12 * public/WebFrame.h: 13 (WebFrame): 14 * src/WebFrameImpl.cpp: 15 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint): 16 (WebKit): 17 * src/WebFrameImpl.h: 18 (WebFrameImpl): 19 1 20 2013-01-04 James Robinson <jamesr@chromium.org> 2 21 -
trunk/Source/WebKit/chromium/public/WebFrame.h
r133006 r138893 471 471 virtual void selectRange(const WebRange&) = 0; 472 472 473 virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0; 474 473 475 // Printing ------------------------------------------------------------ 474 476 -
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
r137318 r138893 1389 1389 } 1390 1390 1391 void WebFrameImpl::moveCaretSelectionTowardsWindowPoint(const WebPoint& point) 1392 { 1393 Element* editable = frame()->selection()->rootEditableElement(); 1394 IntPoint contentsPoint = frame()->view()->windowToContents(IntPoint(point)); 1395 LayoutPoint localPoint(editable->convertFromPage(contentsPoint)); 1396 VisiblePosition position = editable->renderer()->positionForPoint(localPoint); 1397 if (frame()->selection()->shouldChangeSelection(position)) 1398 frame()->selection()->moveTo(position, UserTriggered); 1399 } 1400 1391 1401 VisiblePosition WebFrameImpl::visiblePositionForWindowPoint(const WebPoint& point) 1392 1402 { -
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
r133006 r138893 191 191 virtual void selectRange(const WebPoint& base, const WebPoint& extent); 192 192 virtual void selectRange(const WebRange&); 193 virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&); 193 194 virtual int printBegin(const WebPrintParams&, 194 195 const WebNode& constrainToNode,
Note: See TracChangeset
for help on using the changeset viewer.