Changeset 138902 in webkit

Timestamp:

Jan 5, 2013 12:49:15 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

MediaControls::show() should make controls opaque
​https://bugs.webkit.org/show_bug.cgi?id=106034

Patch by Min Qin <​qinmin@chromium.org> on 2013-01-05
Reviewed by Eric Carlson.

Source/WebCore:

When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
However, show() actually displays nothing as the control is transparent.
The user had to move his mouse outside the video rect and move it back in order to show the controls.
Simply clicking/moving the mouse inside the video rect will not make the control opaque.
Test: media/video-controls-visible-exiting-fullscreen.html

• html/shadow/MediaControls.cpp:

(WebCore::MediaControls::show):

LayoutTests:

Add tests to check that video controls are shown when exiting from fullscreen.

• media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
• media/video-controls-visible-exiting-fullscreen.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/video-controls-visible-exiting-fullscreen-expected.txt (added)
• LayoutTests/media/video-controls-visible-exiting-fullscreen.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/shadow/MediaControls.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-05  Min Qin  <qinmin@chromium.org>
+
+        MediaControls::show() should make controls opaque
+        https://bugs.webkit.org/show_bug.cgi?id=106034
+
+        Reviewed by Eric Carlson.
+
+        Add tests to check that video controls are shown when exiting from fullscreen.
+
+        * media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
+        * media/video-controls-visible-exiting-fullscreen.html: Added.
+
 2013-01-05  Michael Pruett  <michael@68k.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-05  Min Qin  <qinmin@chromium.org>
+
+        MediaControls::show() should make controls opaque
+        https://bugs.webkit.org/show_bug.cgi?id=106034
+
+        Reviewed by Eric Carlson.
+
+        When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
+        If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
+        However, show() actually displays nothing as the control is transparent.
+        The user had to move his mouse outside the video rect and move it back in order to show the controls.
+        Simply clicking/moving the mouse inside the video rect will not make the control opaque.
+        Test: media/video-controls-visible-exiting-fullscreen.html
+
+        * html/shadow/MediaControls.cpp:
+        (WebCore::MediaControls::show):
+
 2013-01-05  Alec Flett  <alecflett@chromium.org>
 

trunk/Source/WebCore/html/shadow/MediaControls.cpp

@@ -152 +152 @@
 void MediaControls::show()
 {
+    makeOpaque();
     m_panel->setIsDisplayed(true);
     m_panel->show();