Changeset 139026 in webkit

Timestamp:

Jan 7, 2013 6:58:15 PM (11 years ago)

Author:

senorblanco@chromium.org

Message:

Add a flag to control canvas antialiasing.
​https://bugs.webkit.org/show_bug.cgi?id=106255

Reviewed by Darin Fisher.

Source/WebCore:

This flag is not exposed through TestRunner or DRT, so no testing is
possible yet.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

• page/Settings.in:

Source/WebKit/chromium:

• public/WebSettings.h:
• src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAntialiased2dCanvasEnabled):

• src/WebSettingsImpl.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLCanvasElement.cpp (modified) (1 diff)
• WebCore/page/Settings.in (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebSettings.h (modified) (1 diff)
• WebKit/chromium/src/WebSettingsImpl.cpp (modified) (1 diff)
• WebKit/chromium/src/WebSettingsImpl.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-07  Stephen White  <senorblanco@chromium.org>
+
+        Add a flag to control canvas antialiasing.
+        https://bugs.webkit.org/show_bug.cgi?id=106255
+
+        Reviewed by Darin Fisher.
+
+        This flag is not exposed through TestRunner or DRT, so no testing is
+        possible yet.
+
+        * html/HTMLCanvasElement.cpp:
+        (WebCore::HTMLCanvasElement::createImageBuffer):
+        * page/Settings.in:
+
 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/Source/WebCore/html/HTMLCanvasElement.cpp

@@ -571 +571 @@
     m_imageBuffer->context()->setShadowsIgnoreTransforms(true);
     m_imageBuffer->context()->setImageInterpolationQuality(DefaultInterpolationQuality);
+    if (document()->settings() && !document()->settings()->antialiased2dCanvasEnabled())
+        m_imageBuffer->context()->setShouldAntialias(false);
     m_imageBuffer->context()->setStrokeThickness(1);
     m_contextStateSaver = adoptPtr(new GraphicsContextStateSaver(*m_imageBuffer->context()));

trunk/Source/WebCore/page/Settings.in

@@ -102 +102 @@
 accelerated2dCanvasEnabled initial=false
 deferred2dCanvasEnabled initial=false
+antialiased2dCanvasEnabled initial=true
 loadDeferringEnabled initial=true
 webAudioEnabled initial=false

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-01-07  Stephen White  <senorblanco@chromium.org>
+
+        Add a flag to control canvas antialiasing.
+        https://bugs.webkit.org/show_bug.cgi?id=106255
+
+        Reviewed by Darin Fisher.
+
+        * public/WebSettings.h:
+        * src/WebSettingsImpl.cpp:
+        (WebKit::WebSettingsImpl::setAntialiased2dCanvasEnabled):
+        * src/WebSettingsImpl.h:
+
 2013-01-07  Yusuf Ozuysal  <yusufo@google.com>
 

trunk/Source/WebKit/chromium/public/WebSettings.h

@@ -73 +73 @@
     virtual void setAllowScriptsToCloseWindows(bool) = 0;
     virtual void setAllowUniversalAccessFromFileURLs(bool) = 0;
+    virtual void setAntialiased2dCanvasEnabled(bool) = 0;
     virtual void setApplyDeviceScaleFactorInCompositor(bool) = 0;
     virtual void setApplyPageScaleFactorInCompositor(bool) = 0;

trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp

@@ -505 +505 @@
 }
 
+void WebSettingsImpl::setAntialiased2dCanvasEnabled(bool enabled)
+{
+    m_settings->setAntialiased2dCanvasEnabled(enabled);
+}
+
 void WebSettingsImpl::setDeferred2dCanvasEnabled(bool enabled)
 {

trunk/Source/WebKit/chromium/src/WebSettingsImpl.h

@@ -67 +67 @@
     virtual void setAllowScriptsToCloseWindows(bool);
     virtual void setAllowUniversalAccessFromFileURLs(bool);
+    virtual void setAntialiased2dCanvasEnabled(bool);
     virtual void setApplyDeviceScaleFactorInCompositor(bool);
     virtual void setApplyPageScaleFactorInCompositor(bool);