Changeset 139102 in webkit

Timestamp:

Jan 8, 2013 1:25:28 PM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
​https://bugs.webkit.org/show_bug.cgi?id=106364

Reviewed by Eric Seidel.

When the setup_test_run method is called on the subclasses of the base Port
interface, the parent method should also be called via super(), despite the
parent method not doing anything at the moment.

The according calls to super() are required in the ChromiumPort, EflPort
and GtkPort implementations.

• Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.setup_test_run):

• Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.setup_test_run):

• Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_test_run):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/efl.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/gtk.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
+
+        [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
+        https://bugs.webkit.org/show_bug.cgi?id=106364
+
+        Reviewed by Eric Seidel.
+
+        When the setup_test_run method is called on the subclasses of the base Port
+        interface, the parent method should also be called via super(), despite the
+        parent method not doing anything at the moment.
+
+        The according calls to super() are required in the ChromiumPort, EflPort
+        and GtkPort implementations.
+
+        * Scripts/webkitpy/layout_tests/port/chromium.py:
+        (ChromiumPort.setup_test_run):
+        * Scripts/webkitpy/layout_tests/port/efl.py:
+        (EflPort.setup_test_run):
+        * Scripts/webkitpy/layout_tests/port/gtk.py:
+        (GtkPort.setup_test_run):
+
 2013-01-08  Julie Parent  <jparent@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py

@@ -289 +289 @@
 
     def setup_test_run(self):
+        super(ChromiumPort, self).setup_test_run()
         # Delete the disk cache if any to ensure a clean test run.
         dump_render_tree_binary_path = self._path_to_driver()

trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py

@@ -53 +53 @@
 
     def setup_test_run(self):
+        super(EflPort, self).setup_test_run()
         self._pulseaudio_sanitizer.unload_pulseaudio_module()
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py

@@ -58 +58 @@
 
     def setup_test_run(self):
+        super(GtkPort, self).setup_test_run()
         self._pulseaudio_sanitizer.unload_pulseaudio_module()