Changeset 139151 in webkit

Timestamp:

Jan 8, 2013 8:17:46 PM (11 years ago)

Author:

tkent@chromium.org

Message:

REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value=""
​https://bugs.webkit.org/show_bug.cgi?id=106284

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. Updates fast/forms/number/number/validity-badinput.html.

• html/NumberInputType.cpp:

(WebCore::NumberInputType::setValue):
If the new sanitized value is empty and innerTextValue is a bad input
(it means !valueChanged && !innerTextValue().isEmpty() because the new
sanitized value is empty), we need to update innerTextValue with the
empty string.

• html/NumberInputType.h:

(NumberInputType): Declare setValue.

LayoutTests:

• fast/forms/number/number-validity-badinput.html:

Add a test case.

• fast/forms/number/number-validity-badinput-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/number/number-validity-badinput-expected.txt (modified) (1 diff)
• LayoutTests/fast/forms/number/number-validity-badinput.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/NumberInputType.cpp (modified) (1 diff)
• Source/WebCore/html/NumberInputType.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-08  Kent Tamura  <tkent@chromium.org>
+
+        REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value=""
+        https://bugs.webkit.org/show_bug.cgi?id=106284
+
+        Reviewed by Hajime Morita.
+
+        * fast/forms/number/number-validity-badinput.html:
+        Add a test case.
+        * fast/forms/number/number-validity-badinput-expected.txt:
+
 2013-01-08  Nate Chapin  <japhet@chromium.org>
 

trunk/LayoutTests/fast/forms/number/number-validity-badinput-expected.txt

@@ -27 +27 @@
 The element losts a renderer. The element state should not be changed.
 PASS number.style.display = "none"; number.validity.badInput is true
+A bad input should be cleared by value="".
+PASS number.value = ""; document.execCommand("SelectAll"); document.getSelection().toString() is ""
 PASS successfullyParsed is true
 

trunk/LayoutTests/fast/forms/number/number-validity-badinput.html

@@ -60 +60 @@
 shouldBeTrue('number.style.display = "none"; number.validity.badInput');
 
+number.style.display = 'inline-block';
+number.focus();
+debug('A bad input should be cleared by value="".');
+shouldBeEqualToString('number.value = ""; document.execCommand("SelectAll"); document.getSelection().toString()', '');
+
 document.getElementById('parent').innerHTML = '';
 </script>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-08  Kent Tamura  <tkent@chromium.org>
+
+        REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value=""
+        https://bugs.webkit.org/show_bug.cgi?id=106284
+
+        Reviewed by Hajime Morita.
+
+        No new tests. Updates fast/forms/number/number/validity-badinput.html.
+
+        * html/NumberInputType.cpp:
+        (WebCore::NumberInputType::setValue):
+        If the new sanitized value is empty and innerTextValue is a bad input
+        (it means !valueChanged && !innerTextValue().isEmpty() because the new
+        sanitized value is empty), we need to update innerTextValue with the
+        empty string.
+        * html/NumberInputType.h:
+        (NumberInputType): Declare setValue.
+
 2013-01-08  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/html/NumberInputType.cpp

@@ -107 +107 @@
 }
 
+void NumberInputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior)
+{
+    if (!valueChanged && sanitizedValue.isEmpty() && !element()->innerTextValue().isEmpty())
+        updateInnerTextValue();
+    TextFieldInputType::setValue(sanitizedValue, valueChanged, eventBehavior);
+}
+
 double NumberInputType::valueAsDouble() const
 {

trunk/Source/WebCore/html/NumberInputType.h

@@ -43 +43 @@
     NumberInputType(HTMLInputElement* element) : TextFieldInputType(element) { }
     virtual const AtomicString& formControlType() const OVERRIDE;
+    virtual void setValue(const String&, bool valueChanged, TextFieldEventBehavior) OVERRIDE;
     virtual double valueAsDouble() const OVERRIDE;
     virtual void setValueAsDouble(double, TextFieldEventBehavior, ExceptionCode&) const OVERRIDE;