Changeset 139151 in webkit
- Timestamp:
- Jan 8, 2013 8:17:46 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r139150 r139151 1 2013-01-08 Kent Tamura <tkent@chromium.org> 2 3 REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value="" 4 https://bugs.webkit.org/show_bug.cgi?id=106284 5 6 Reviewed by Hajime Morita. 7 8 * fast/forms/number/number-validity-badinput.html: 9 Add a test case. 10 * fast/forms/number/number-validity-badinput-expected.txt: 11 1 12 2013-01-08 Nate Chapin <japhet@chromium.org> 2 13 -
trunk/LayoutTests/fast/forms/number/number-validity-badinput-expected.txt
r135838 r139151 27 27 The element losts a renderer. The element state should not be changed. 28 28 PASS number.style.display = "none"; number.validity.badInput is true 29 A bad input should be cleared by value="". 30 PASS number.value = ""; document.execCommand("SelectAll"); document.getSelection().toString() is "" 29 31 PASS successfullyParsed is true 30 32 -
trunk/LayoutTests/fast/forms/number/number-validity-badinput.html
r135838 r139151 60 60 shouldBeTrue('number.style.display = "none"; number.validity.badInput'); 61 61 62 number.style.display = 'inline-block'; 63 number.focus(); 64 debug('A bad input should be cleared by value="".'); 65 shouldBeEqualToString('number.value = ""; document.execCommand("SelectAll"); document.getSelection().toString()', ''); 66 62 67 document.getElementById('parent').innerHTML = ''; 63 68 </script> -
trunk/Source/WebCore/ChangeLog
r139150 r139151 1 2013-01-08 Kent Tamura <tkent@chromium.org> 2 3 REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value="" 4 https://bugs.webkit.org/show_bug.cgi?id=106284 5 6 Reviewed by Hajime Morita. 7 8 No new tests. Updates fast/forms/number/number/validity-badinput.html. 9 10 * html/NumberInputType.cpp: 11 (WebCore::NumberInputType::setValue): 12 If the new sanitized value is empty and innerTextValue is a bad input 13 (it means !valueChanged && !innerTextValue().isEmpty() because the new 14 sanitized value is empty), we need to update innerTextValue with the 15 empty string. 16 * html/NumberInputType.h: 17 (NumberInputType): Declare setValue. 18 1 19 2013-01-08 Nate Chapin <japhet@chromium.org> 2 20 -
trunk/Source/WebCore/html/NumberInputType.cpp
r135836 r139151 107 107 } 108 108 109 void NumberInputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior) 110 { 111 if (!valueChanged && sanitizedValue.isEmpty() && !element()->innerTextValue().isEmpty()) 112 updateInnerTextValue(); 113 TextFieldInputType::setValue(sanitizedValue, valueChanged, eventBehavior); 114 } 115 109 116 double NumberInputType::valueAsDouble() const 110 117 { -
trunk/Source/WebCore/html/NumberInputType.h
r135836 r139151 43 43 NumberInputType(HTMLInputElement* element) : TextFieldInputType(element) { } 44 44 virtual const AtomicString& formControlType() const OVERRIDE; 45 virtual void setValue(const String&, bool valueChanged, TextFieldEventBehavior) OVERRIDE; 45 46 virtual double valueAsDouble() const OVERRIDE; 46 47 virtual void setValueAsDouble(double, TextFieldEventBehavior, ExceptionCode&) const OVERRIDE;
Note: See TracChangeset
for help on using the changeset viewer.