Changeset 139188 in webkit

Timestamp:

Jan 9, 2013 5:33:47 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: cannot undock inspector when window size is too small
​https://bugs.webkit.org/show_bug.cgi?id=106054

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-09
Reviewed by Pavel Feldman.

Consider dockingUnavailable flag only when dockSide is in undocked
state.

• inspector/front-end/DockController.js:

(WebInspector.DockController.prototype._updateUI.get document):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DockController.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-09  Arnaud Renevier  <a.renevier@sisa.samsung.com>
+
+        Web Inspector: cannot undock inspector when window size is too small
+        https://bugs.webkit.org/show_bug.cgi?id=106054
+
+        Reviewed by Pavel Feldman.
+
+        Consider dockingUnavailable flag only when dockSide is in undocked
+        state.
+
+        * inspector/front-end/DockController.js:
+        (WebInspector.DockController.prototype._updateUI.get document):
+
 2013-01-09  Zeno Albisser  <zeno@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/DockController.js

@@ -116 +116 @@
             document.body.removeStyleClass("show-toolbar-icons");
 
-        if (this._isDockingUnavailable) {
+        if (this._isDockingUnavailable && this._dockSide === WebInspector.DockController.State.Undocked) {
             this._dockToggleButton.state = "undock";
             this._dockToggleButton.setEnabled(false);