Changeset 139193 in webkit

Timestamp:

Jan 9, 2013 7:38:14 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=106442

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2013-01-09
Reviewed by Kentaro Hara.

IDBLevelDBCoding::m_metaDataType has been changed to unsigned
so ASSERT(m_metaDataType >= 0) is no longer useful: the compiler
warnings however create build difficulties at least with EFL.

• Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBLevelDBCoding.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-09  Jussi Kukkonen  <jussi.kukkonen@intel.com>
+
+        IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=106442
+
+        Reviewed by Kentaro Hara.
+
+        IDBLevelDBCoding::m_metaDataType has been changed to unsigned
+        so ASSERT(m_metaDataType >= 0) is no longer useful: the compiler
+        warnings however create build difficulties at least with EFL.
+
+        * Modules/indexeddb/IDBLevelDBCoding.cpp:
+        (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
+        (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
+
 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp

@@ -1224 +1224 @@
 unsigned char ObjectStoreMetaDataKey::metaDataType() const
 {
-    ASSERT(m_metaDataType >= 0);
     return m_metaDataType;
 }
@@ -1231 +1230 @@
 {
     ASSERT(m_objectStoreId >= 0);
-    ASSERT(m_metaDataType >= 0);
     if (int x = compareInts(m_objectStoreId, other.m_objectStoreId))
         return x;