Changeset 139545 in webkit

Timestamp:

Jan 11, 2013 11:03:18 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
​https://bugs.webkit.org/show_bug.cgi?id=106610

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-11
Reviewed by Darin Fisher.

Source/WebCore:

No new tests (none needed).

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::finishRequestAutocomplete): Removed handling of AutocompleteResultError.

• html/HTMLFormElement.h: Removed HTMLFormElement::AutocompleteResultError in favor of more specific errors.

Source/WebKit/chromium:

• public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
• src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLFormElement.cpp (modified) (1 diff)
• WebCore/html/HTMLFormElement.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebFormElement.h (modified) (1 diff)
• WebKit/chromium/src/AssertMatchingEnums.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-11  Dan Beam  <dbeam@chromium.org>
+
+        [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
+        https://bugs.webkit.org/show_bug.cgi?id=106610
+
+        Reviewed by Darin Fisher.
+
+        No new tests (none needed).
+
+        * html/HTMLFormElement.cpp: 
+        (WebCore::HTMLFormElement::finishRequestAutocomplete): Removed handling of AutocompleteResultError.
+        * html/HTMLFormElement.h: Removed HTMLFormElement::AutocompleteResultError in favor of more specific errors.
+
 2013-01-10  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/WebCore/html/HTMLFormElement.cpp

@@ -416 +416 @@
     if (result == AutocompleteResultSuccess)
         event = Event::create(eventNames().autocompleteEvent, false, false);
-    else if (result == AutocompleteResultError) // FIXME: Remove when no longer used.
-        event = Event::create(eventNames().autocompleteerrorEvent, false, false);
     else if (result == AutocompleteResultErrorDisabled)
         event = AutocompleteErrorEvent::create("disabled");

trunk/Source/WebCore/html/HTMLFormElement.h

@@ -102 +102 @@
     enum AutocompleteResult {
         AutocompleteResultSuccess,
-        AutocompleteResultError, // FIXME: Remove when no longer used.
         AutocompleteResultErrorDisabled,
         AutocompleteResultErrorCancel,

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-01-11  Dan Beam  <dbeam@chromium.org>
+
+        [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
+        https://bugs.webkit.org/show_bug.cgi?id=106610
+
+        Reviewed by Darin Fisher.
+
+        * public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
+        * src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
+
 2013-01-11  Tien-Ren Chen  <trchen@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebFormElement.h

@@ -72 +72 @@
         enum AutocompleteResult {
             AutocompleteResultSuccess,
-            AutocompleteResultError, // FIXME: Remove when not used any more.
             AutocompleteResultErrorDisabled,
             AutocompleteResultErrorCancel,

trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp

@@ -628 +628 @@
 #if ENABLE(REQUEST_AUTOCOMPLETE)
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultSuccess, HTMLFormElement::AutocompleteResultSuccess);
-COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultError, HTMLFormElement::AutocompleteResultError);
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultErrorDisabled, HTMLFormElement::AutocompleteResultErrorDisabled);
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultErrorCancel, HTMLFormElement::AutocompleteResultErrorCancel);