Changeset 139615 in webkit

Timestamp:

Jan 14, 2013 8:33:45 AM (11 years ago)

Author:

eric.carlson@apple.com

Message:

Do not pass nil when initializing legible output
​https://bugs.webkit.org/show_bug.cgi?id=106799

Reviewed by Jessie Berlin.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]

wants an empty NSArray rather than nil.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Eric Carlson  <eric.carlson@apple.com>
+
+        Do not pass nil when initializing legible output
+        https://bugs.webkit.org/show_bug.cgi?id=106799
+
+        Reviewed by Jessie Berlin.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]
+            wants an empty NSArray rather than nil.
+
 2013-01-14  Andrey Adaikin  <aandrey@chromium.org>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -889 +889 @@
 #if HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
     if (m_avPlayerItem && !m_legibleOutput) {
-        m_legibleOutput = adoptNS([[AVPlayerItemLegibleOutput alloc] initWithMediaSubtypesForNativeRepresentation:nil]);
+        m_legibleOutput = adoptNS([[AVPlayerItemLegibleOutput alloc] initWithMediaSubtypesForNativeRepresentation:[NSArray array]]);
         [m_legibleOutput.get() setSuppressesPlayerRendering:YES];