Changeset 139652 in webkit

Timestamp:

Jan 14, 2013 1:21:37 PM (11 years ago)

Author:

pilgrim@chromium.org

Message:

[Chromium] Move AudioDestinationChromium into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106803

Reviewed by Adam Barth.

This doesn't really belong in WebKit/chromium/src since it defines
things directly in the WebCore namespace.

Source/WebCore:

• WebCore.gypi:
• platform/audio/chromium/AudioDestinationChromium.cpp: Added.

(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationChromium::render):
(WebCore::AudioDestinationChromium::provideInput):

• platform/audio/chromium/AudioDestinationChromium.h: Added.

(WebCore):
(AudioDestinationChromium):
(WebCore::AudioDestinationChromium::isPlaying):
(WebCore::AudioDestinationChromium::sampleRate):

Source/WebKit/chromium:

• WebKit.gyp:
• src/AudioDestinationChromium.cpp: Removed.
• src/AudioDestinationChromium.h: Removed.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.gypi (modified) (1 diff)
• WebCore/platform/audio/chromium/AudioDestinationChromium.cpp (moved) (moved from trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp) (2 diffs)
• WebCore/platform/audio/chromium/AudioDestinationChromium.h (moved) (moved from trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/WebKit.gyp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
+
+        [Chromium] Move AudioDestinationChromium into WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=106803
+
+        Reviewed by Adam Barth.
+
+        This doesn't really belong in WebKit/chromium/src since it defines
+        things directly in the WebCore namespace.
+
+        * WebCore.gypi:
+        * platform/audio/chromium/AudioDestinationChromium.cpp: Added.
+        (WebCore):
+        (WebCore::AudioDestination::create):
+        (WebCore::AudioDestinationChromium::AudioDestinationChromium):
+        (WebCore::AudioDestinationChromium::~AudioDestinationChromium):
+        (WebCore::AudioDestinationChromium::start):
+        (WebCore::AudioDestinationChromium::stop):
+        (WebCore::AudioDestination::hardwareSampleRate):
+        (WebCore::AudioDestinationChromium::render):
+        (WebCore::AudioDestinationChromium::provideInput):
+        * platform/audio/chromium/AudioDestinationChromium.h: Added.
+        (WebCore):
+        (AudioDestinationChromium):
+        (WebCore::AudioDestinationChromium::isPlaying):
+        (WebCore::AudioDestinationChromium::sampleRate):
+
 2013-01-14  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebCore/WebCore.gypi

@@ -3617 +3617 @@
             'platform/audio/ZeroPole.h',
             'platform/audio/chromium/AudioBusChromium.cpp',
+            'platform/audio/chromium/AudioDestinationChromium.cpp',
+            'platform/audio/chromium/AudioDestinationChromium.h',
             'platform/audio/mac/AudioBusMac.mm',
             'platform/audio/mac/AudioDestinationMac.cpp',

trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp

@@ -30 +30 @@
 
 #if ENABLE(WEB_AUDIO)
+
 #include "AudioDestinationChromium.h"
+
 #include "AudioFIFO.h"
 #include "AudioPullFIFO.h"
 #include <public/Platform.h>
-
-using namespace WebKit;
 
 namespace WebCore {
@@ -116 +116 @@
 }
 
-void AudioDestinationChromium::render(const WebVector<float*>& sourceData, const WebVector<float*>& audioData, size_t numberOfFrames)
+void AudioDestinationChromium::render(const WebKit::WebVector<float*>& sourceData, const WebKit::WebVector<float*>& audioData, size_t numberOfFrames)
 {
     bool isNumberOfChannelsGood = audioData.size() == m_numberOfOutputChannels;

trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.h

@@ -36 +36 @@
 #include <public/WebAudioDevice.h>
 #include <public/WebVector.h>
-
-namespace WebKit { class WebAudioDevice; }
 
 namespace WebCore { 

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
+
+        [Chromium] Move AudioDestinationChromium into WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=106803
+
+        Reviewed by Adam Barth.
+
+        This doesn't really belong in WebKit/chromium/src since it defines
+        things directly in the WebCore namespace.
+
+        * WebKit.gyp:
+        * src/AudioDestinationChromium.cpp: Removed.
+        * src/AudioDestinationChromium.h: Removed.
+
 2013-01-14  Stephen Chenney  <schenney@chromium.org>
 

trunk/Source/WebKit/chromium/WebKit.gyp

@@ -351 +351 @@
                 'src/AsyncFileWriterChromium.cpp',
                 'src/AsyncFileWriterChromium.h',
-                'src/AudioDestinationChromium.cpp',
-                'src/AudioDestinationChromium.h',
                 'src/AutofillPopupMenuClient.cpp',
                 'src/AutofillPopupMenuClient.h',