Changeset 139787 in webkit

Timestamp:

Jan 15, 2013 2:04:29 PM (11 years ago)

Author:

mifenton@rim.com

Message:

[BlackBerry] Don't overwrite field dir with current locale.
​https://bugs.webkit.org/show_bug.cgi?id=106932

Reviewed by Yong Li.

PR 212267.

Remove uncalled onInputLocaleChanged and stop re-writing the dir
on input focus which prevented RTL fields from rendering properly.

Reviewed Internally by Eli Fidler.

• Api/WebPage.cpp:
• Api/WebPage.h:
• Api/WebPage_p.h:

(WebPagePrivate):

• WebKitSupport/InputHandler.cpp:
• WebKitSupport/InputHandler.h:

(InputHandler):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (1 diff)
• Api/WebPage.h (modified) (1 diff)
• Api/WebPage_p.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• WebKitSupport/InputHandler.cpp (modified) (1 diff)
• WebKitSupport/InputHandler.h (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -3518 +3518 @@
 }
 
-void WebPagePrivate::onInputLocaleChanged(bool isRTL)
-{
-    if (isRTL != m_webSettings->isWritingDirectionRTL()) {
-        m_webSettings->setWritingDirectionRTL(isRTL);
-        m_inputHandler->handleInputLocaleChanged(isRTL);
-    }
-}
-
-void WebPage::onInputLocaleChanged(bool isRTL)
-{
-    d->onInputLocaleChanged(isRTL);
-}
-
 void WebPagePrivate::suspendBackingStore()
 {

trunk/Source/WebKit/blackberry/Api/WebPage.h

@@ -265 +265 @@
     void setColorInput(const BlackBerry::Platform::String& value);
 
-    void onInputLocaleChanged(bool isRTL);
     static void onNetworkAvailabilityChanged(bool available);
     static void onCertificateStoreLocationSet(const BlackBerry::Platform::String& caPath);

trunk/Source/WebKit/blackberry/Api/WebPage_p.h

@@ -327 +327 @@
     void updateCursor();
 
-    void onInputLocaleChanged(bool isRTL);
-
     ViewMode viewMode() const { return m_viewMode; }
     bool setViewMode(ViewMode); // Returns true if the change requires re-layout.

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-01-15  Mike Fenton  <mifenton@rim.com>
+
+        [BlackBerry] Don't overwrite field dir with current locale.
+        https://bugs.webkit.org/show_bug.cgi?id=106932
+
+        Reviewed by Yong Li.
+
+        PR 212267.
+
+        Remove uncalled onInputLocaleChanged and stop re-writing the dir
+        on input focus which prevented RTL fields from rendering properly.
+
+        Reviewed Internally by Eli Fidler.
+
+        * Api/WebPage.cpp:
+        * Api/WebPage.h:
+        * Api/WebPage_p.h:
+        (WebPagePrivate):
+        * WebKitSupport/InputHandler.cpp:
+        * WebKitSupport/InputHandler.h:
+        (InputHandler):
+
 2013-01-15  Jacky Jiang  <zhajiang@rim.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

@@ -1739 +1739 @@
 }
 
-void InputHandler::handleInputLocaleChanged(bool isRTL)
-{
-    if (!isActiveTextEdit())
-        return;
-
-    ASSERT(m_currentFocusElement->document() && m_currentFocusElement->document()->frame());
-    RenderObject* renderer = m_currentFocusElement->renderer();
-    if (!renderer)
-        return;
-
-    Editor* editor = m_currentFocusElement->document()->frame()->editor();
-    ASSERT(editor);
-    if ((renderer->style()->direction() == RTL) != isRTL)
-        editor->setBaseWritingDirection(isRTL ? RightToLeftWritingDirection : LeftToRightWritingDirection);
-}
-
 void InputHandler::clearCurrentFocusElement()
 {

trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h

@@ -105 +105 @@
 
     void ensureFocusElementVisible(bool centerFieldInDisplay = true);
-    void handleInputLocaleChanged(bool isRTL);
 
     // PopupMenu methods.