Changeset 13981 in webkit

Timestamp:

Apr 19, 2006 7:33:53 PM (18 years ago)

Author:

thatcher

Message:

Reviewed by Hyatt.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8352 CSS text-shadow does not repaint completely when changed

• manual-tests/dynamic-shadow.html: Added.
• rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow changes.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/render_style.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-04-19  Mitz Pettel  <opendarwin.org@mitzpettel.com>
+
+        Reviewed by Hyatt.
+
+        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8352
+          CSS text-shadow does not repaint completely when changed
+
+        * manual-tests/dynamic-shadow.html: Added.
+        * rendering/render_style.cpp:
+        (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow
+        changes.
+
 2006-04-19  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/rendering/render_style.cpp

@@ -816 +816 @@
          !(inherited_flags._direction == other->inherited_flags._direction) ||
          !(inherited_flags._white_space == other->inherited_flags._white_space) ||
-         !(noninherited_flags._clear == other->noninherited_flags._clear)
+         !(noninherited_flags._clear == other->noninherited_flags._clear) ||
+         !css3InheritedData->shadowDataEquivalent(*other->css3InheritedData.get())
         )
         return Layout;
@@ -872 +873 @@
         *background.get() != *other->background.get() ||
         visual->textDecoration != other->visual->textDecoration ||
-        !css3InheritedData->shadowDataEquivalent(*other->css3InheritedData.get()) ||
         css3InheritedData->userModify != other->css3InheritedData->userModify ||
         css3NonInheritedData->userSelect != other->css3NonInheritedData->userSelect ||