Changeset 139870 in webkit

Timestamp:

Jan 16, 2013 4:13:45 AM (11 years ago)

Author:

zeno.albisser@digia.com

Message:

GraphicsSurfaceGLX is leaking an XWindow
​https://bugs.webkit.org/show_bug.cgi?id=107002

The XWindow created as a backing surface for
the GraphicsSurfaceGLX needs to be destroyed
together with the GraphicsSurface.

Reviewed by Noam Rosenthal.

• platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::clear):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Zeno Albisser  <zeno@webkit.org>
+
+        GraphicsSurfaceGLX is leaking an XWindow
+        https://bugs.webkit.org/show_bug.cgi?id=107002
+
+        The XWindow created as a backing surface for
+        the GraphicsSurfaceGLX needs to be destroyed
+        together with the GraphicsSurface.
+
+        Reviewed by Noam Rosenthal.
+
+        * platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+        (WebCore::GraphicsSurfacePrivate::clear):
+
 2013-01-16  Pablo Flouret  <pablof@motorola.com>
 

trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp

@@ -438 +438 @@
             XFreePixmap(m_display, m_xPixmap);
             m_xPixmap = 0;
+        }
+
+        if (m_surface) {
+            XDestroyWindow(m_display, m_surface);
+            m_surface = 0;
         }