Changeset 139929 in webkit

Timestamp:

Jan 16, 2013 3:11:07 PM (11 years ago)

Author:

jsbell@chromium.org

Message:

IndexedDB: Possible null ScriptExecutionContext passed to callbacks during frame destruction
​https://bugs.webkit.org/show_bug.cgi?id=107050

Reviewed by Tony Chang.

Temporary code to defend against null contexts. Will either refute a hypothesis, or we'll
need to make a more systemic fix elsewhere. Either way it will be removed in a few days.
We're unable to repro, but watching crash reports from users. One possible source is
that during page tear-down WorkerScriptController::controllerForContext() returns null
(there's a comment about that case) leading to a null context.

No new tests - this shouldn't be happening.

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBObjectStore.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-16  Joshua Bell  <jsbell@chromium.org>
+
+        IndexedDB: Possible null ScriptExecutionContext passed to callbacks during frame destruction
+        https://bugs.webkit.org/show_bug.cgi?id=107050
+
+        Reviewed by Tony Chang.
+
+        Temporary code to defend against null contexts. Will either refute a hypothesis, or we'll
+        need to make a more systemic fix elsewhere. Either way it will be removed in a few days.
+        We're unable to repro, but watching crash reports from users. One possible source is
+        that during page tear-down WorkerScriptController::controllerForContext() returns null
+        (there's a comment about that case) leading to a null context.
+
+        No new tests - this shouldn't be happening.
+
+        * Modules/indexeddb/IDBObjectStore.cpp:
+        (WebCore::IDBObjectStore::createIndex):
+
 2013-01-16  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp

@@ -357 +357 @@
 {
     IDB_TRACE("IDBObjectStore::createIndex");
+    // FIXME: Temporary code to determine if null contexts are plausible during frame destruction.
+    // https://bugs.webkit.org/show_bug.cgi?id=107050
+    ASSERT(context);
+    if (!context)
+        return 0;
+
     if (!m_transaction->isVersionChange() || m_deleted) {
         ec = IDBDatabaseException::InvalidStateError;