Changeset 140063 in webkit

Timestamp:

Jan 17, 2013 4:04:37 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer.
​https://bugs.webkit.org/show_bug.cgi?id=107090

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-17
Reviewed by Noam Rosenthal.

GraphicsLayer initializes m_anchorPoint to FloatPoint3D(0.5, 0.5, 0) and
m_preserves3D to false, while GraphicsLayerTransform initializes m_anchorPoint
to FloatPoint3D(0, 0, 0) and m_flattening (= !m_preserves3D) to false. It is a
potential bug. This patch corrects initialization of GraphicsLayerTransform.

Covered by existing compositing pixel tests.

• platform/graphics/GraphicsLayerTransform.cpp:

(WebCore::GraphicsLayerTransform::GraphicsLayerTransform):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GraphicsLayerTransform.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-17  Huang Dongsung  <luxtella@company100.net>
+
+        [TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer.
+        https://bugs.webkit.org/show_bug.cgi?id=107090
+
+        Reviewed by Noam Rosenthal.
+
+        GraphicsLayer initializes m_anchorPoint to FloatPoint3D(0.5, 0.5, 0) and
+        m_preserves3D to false, while GraphicsLayerTransform initializes m_anchorPoint
+        to FloatPoint3D(0, 0, 0) and m_flattening (= !m_preserves3D) to false. It is a
+        potential bug. This patch corrects initialization of GraphicsLayerTransform.
+
+        Covered by existing compositing pixel tests.
+
+        * platform/graphics/GraphicsLayerTransform.cpp:
+        (WebCore::GraphicsLayerTransform::GraphicsLayerTransform):
+
 2013-01-17  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp

@@ -24 +24 @@
 
 GraphicsLayerTransform::GraphicsLayerTransform()
-    : m_flattening(false)
+    : m_anchorPoint(0.5, 0.5, 0)
+    , m_flattening(true)
     , m_dirty(false) // false by default since all default values would be combined as the identity matrix
     , m_childrenDirty(false)