Changeset 140080 in webkit

Timestamp:

Jan 17, 2013 6:06:07 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r139402.
​http://trac.webkit.org/changeset/139402
​https://bugs.webkit.org/show_bug.cgi?id=107212

Perf regression on DOMDivWalk (Requested by falken_ on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-17

Source/WebCore:

• dom/Element.cpp:

(WebCore::Element::removedFrom):
(WebCore::Element::setIsInTopLayer):

LayoutTests:

• fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Removed.
• fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Removed.
• fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Removed.
• fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html (deleted)
• LayoutTests/fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html (deleted)
• LayoutTests/fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html (deleted)
• LayoutTests/fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r139402.
+        http://trac.webkit.org/changeset/139402
+        https://bugs.webkit.org/show_bug.cgi?id=107212
+
+        Perf regression on DOMDivWalk (Requested by falken_ on
+        #webkit).
+
+        * fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Removed.
+        * fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Removed.
+        * fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Removed.
+        * fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Removed.
+
 2013-01-17  Alpha Lam  <hclam@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r139402.
+        http://trac.webkit.org/changeset/139402
+        https://bugs.webkit.org/show_bug.cgi?id=107212
+
+        Perf regression on DOMDivWalk (Requested by falken_ on
+        #webkit).
+
+        * dom/Element.cpp:
+        (WebCore::Element::removedFrom):
+        (WebCore::Element::setIsInTopLayer):
+
 2013-01-17  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1172 +1172 @@
 
 #if ENABLE(DIALOG_ELEMENT)
-    document()->removeFromTopLayer(this);
+    setIsInTopLayer(false);
 #endif
 #if ENABLE(FULLSCREEN_API)
@@ -2403 +2403 @@
 {
     ensureElementRareData()->setIsInTopLayer(inTopLayer);
-
-    // We must ensure a reattach occurs so the renderer is inserted in the correct sibling order under RenderView according to its
-    // top layer position, or in its usual place if not in the top layer.
-    reattachIfAttached();
+    setNeedsStyleRecalc(SyntheticStyleChange);
 }
 #endif