Changeset 140083 in webkit

Timestamp:

Jan 17, 2013 6:16:48 PM (11 years ago)

Author:

jparent@chromium.org

Message:

Flakiness dashboard assumes there must be ToT tests
​https://bugs.webkit.org/show_bug.cgi?id=107155

Remove group as a default parameter, since we can't actually know
the name of a group initially. Instead, introduces
currentBuilderGroupName which returns the current builder group
if it has been explicitly set, or picks the first one available
as a default. Allows us to remove some extra code tracking this
stuff as well.

Reviewed by Ojan Vafai.

• TestResultServer/static-dashboards/dashboard_base.js:

(parseCrossDashboardParameters):
(currentBuilderGroupName):
(currentBuilderGroup):

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(platformAndBuildType):

• TestResultServer/static-dashboards/loader.js:

(.):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/dashboard_base.js (modified) (3 diffs)
• TestResultServer/static-dashboards/flakiness_dashboard.js (modified) (1 diff)
• TestResultServer/static-dashboards/loader.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-17  Julie Parent  <jparent@chromium.org>
+
+        Flakiness dashboard assumes there must be ToT tests
+        https://bugs.webkit.org/show_bug.cgi?id=107155
+
+        Remove group as a default parameter, since we can't actually know
+        the name of a group initially.  Instead, introduces 
+        currentBuilderGroupName which returns the current builder group
+        if it has been explicitly set, or picks the first one available
+        as a default. Allows us to remove some extra code tracking this
+        stuff as well.
+        
+        Reviewed by Ojan Vafai.
+
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (parseCrossDashboardParameters):
+        (currentBuilderGroupName):
+        (currentBuilderGroup):
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        (platformAndBuildType):
+        * TestResultServer/static-dashboards/loader.js:
+        (.):
+
 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js

@@ -197 +197 @@
 
 var g_defaultCrossDashboardStateValues = {
-    group: '@ToT - chromium.org',
     showAllRuns: false,
     testType: 'layout-tests',
@@ -298 +297 @@
 
     fillMissingValues(g_crossDashboardState, g_defaultCrossDashboardStateValues);
-    if (currentBuilderGroup() === undefined)
-        g_crossDashboardState.group = g_defaultCrossDashboardStateValues.group;
 }
 
@@ -413 +410 @@
 }
 
+function currentBuilderGroupName()
+{
+    return g_crossDashboardState.group || Object.keys(currentBuilderGroupCategory())[0];
+}
+
 function currentBuilderGroup()
 {
-    return currentBuilderGroupCategory()[g_crossDashboardState.group]
+    return currentBuilderGroupCategory()[currentBuilderGroupName()];
 }
 

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js

@@ -386 +386 @@
         
         var platform = '';
-        if (isLayoutTestResults() && g_crossDashboardState.group == '@ToT - webkit.org' && !stringContains(builderNameUpperCase, 'CHROMIUM'))
+        if (isLayoutTestResults() && currentBuilderGroupName() == '@ToT - webkit.org' && !stringContains(builderNameUpperCase, 'CHROMIUM'))
             platform = nonChromiumPlatform(builderNameUpperCase);
         else

trunk/Tools/TestResultServer/static-dashboards/loader.js

@@ -95 +95 @@
     _loadBuildersList: function()
     {
-        loadBuildersList(g_crossDashboardState.group, g_crossDashboardState.testType);
+        loadBuildersList(currentBuilderGroupName(), g_crossDashboardState.testType);
         this._loadNext();
     },