Changeset 140128 in webkit

Timestamp:

Jan 18, 2013 4:50:17 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
​https://bugs.webkit.org/show_bug.cgi?id=107215

Patch by Andrew Lo <​anlo@rim.com> on 2013-01-18
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

Internal PR276660
Render jobs should not be performed if the backing store is inactive.

This occured when the browser was invoked, causing a web page to be made
visible before the surface pool was resumed.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/BackingStore.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/BackingStore.cpp

@@ -543 +543 @@
 bool BackingStorePrivate::shouldPerformRenderJobs() const
 {
-    return (m_webPage->isVisible() || shouldDirectRenderingToWindow()) && !m_suspendRenderJobs && !m_suspendBackingStoreUpdates && !m_renderQueue->isEmpty(!m_suspendRegularRenderJobs);
+    return (isActive() || shouldDirectRenderingToWindow()) && !m_suspendRenderJobs && !m_suspendBackingStoreUpdates && !m_renderQueue->isEmpty(!m_suspendRegularRenderJobs);
 }
 

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-01-18  Andrew Lo  <anlo@rim.com>
+
+        [BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
+        https://bugs.webkit.org/show_bug.cgi?id=107215
+
+        Reviewed by Rob Buis.
+        Internally reviewed by Jakob Petsovits.
+
+        Internal PR276660
+        Render jobs should not be performed if the backing store is inactive.
+
+        This occured when the browser was invoked, causing a web page to be made
+        visible before the surface pool was resumed.
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
+
 2013-01-17  Yong Li  <yoli@rim.com>