Changeset 140205 in webkit

Timestamp:

Jan 18, 2013 1:56:24 PM (11 years ago)

Author:

eae@chromium.org

Message:

Update LayoutUnit rounding unit test
​https://bugs.webkit.org/show_bug.cgi?id=107322

Reviewed by Levi Weintraub.

Update the LayoutUnitRounding test to use fromFloatRound for
values that cannot accurately be represented as a LayoutUnit
(the default behavior is to floor the value to the nearest
LayoutUnit).

• TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-18  Emil A Eklund  <eae@chromium.org>
+
+        Update LayoutUnit rounding unit test
+        https://bugs.webkit.org/show_bug.cgi?id=107322
+
+        Reviewed by Levi Weintraub.
+        
+        Update the LayoutUnitRounding test to use fromFloatRound for
+        values that cannot accurately be represented as a LayoutUnit
+        (the default behavior is to floor the value to the nearest
+        LayoutUnit).
+
+        * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
+        (TestWebKitAPI::TEST):
+
 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp

@@ -84 +84 @@
     ASSERT_EQ(LayoutUnit(-1.9f).round(), -2);
     ASSERT_EQ(LayoutUnit(-1.6f).round(), -2);
-    ASSERT_EQ(LayoutUnit(-1.52f).round(), -2);
-    ASSERT_EQ(LayoutUnit(-1.5f).round(), -1);
-    ASSERT_EQ(LayoutUnit(-1.49f).round(), -1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-1.51f).round(), -2);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-1.5f).round(), -1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-1.49f).round(), -1);
     ASSERT_EQ(LayoutUnit(-1.0f).round(), -1);
-    ASSERT_EQ(LayoutUnit(-0.99f).round(), -1);
-    ASSERT_EQ(LayoutUnit(-0.51f).round(), 0);
-    ASSERT_EQ(LayoutUnit(-0.50f).round(), 0);
-    ASSERT_EQ(LayoutUnit(-0.49f).round(), 0);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-0.99f).round(), -1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-0.51f).round(), -1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-0.50f).round(), 0);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(-0.49f).round(), 0);
     ASSERT_EQ(LayoutUnit(-0.1f).round(), 0);
     ASSERT_EQ(LayoutUnit(0.0f).round(), 0);
     ASSERT_EQ(LayoutUnit(0.1f).round(), 0);
-    ASSERT_EQ(LayoutUnit(0.49f).round(), 0);
-    ASSERT_EQ(LayoutUnit(0.50f).round(), 1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(0.49f).round(), 0);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(0.50f).round(), 1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(0.51f).round(), 1);
     ASSERT_EQ(LayoutUnit(0.99f).round(), 1);
     ASSERT_EQ(LayoutUnit(1.0f).round(), 1);
-    ASSERT_EQ(LayoutUnit(1.49f).round(), 1);
-    ASSERT_EQ(LayoutUnit(1.5f).round(), 2);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(1.49f).round(), 1);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(1.5f).round(), 2);
+    ASSERT_EQ(LayoutUnit::fromFloatRound(1.51f).round(), 2);
 }