Changeset 140215 in webkit

Timestamp:

Jan 18, 2013 4:12:54 PM (11 years ago)

Author:

shinyak@chromium.org

Message:

Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement instead of toTextFormControl
​https://bugs.webkit.org/show_bug.cgi?id=107089

Reviewed by Kent Tamura.

Source/WebCore:

toTextFormControl(node) returns 0 if node is not HTMLTextFormControl. In recent coding convention,
we only have ASSERT and statc_cast in this kind of conversion function. So this code looks like
having a bad cast, though it does not.

In this patch, we convert toTextFromControl to isHTMLTextFormControlElement and toHTMLFormControlElement,
which aligns our coding convention.

No new tests, simple refactoring.

• editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::Editor::setBaseWritingDirection):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality):

• html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

• html/HTMLTextFormControlElement.h:

(WebCore::isHTMLTextFormControlElement):
(WebCore):
(WebCore::toHTMLTextFormControlElement):

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::layoutSpecialExcludedChild):

• testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):

Source/WebKit/qt:

Updated code to use isHTMLTextFormControlElement and toHTMLTextFormControlElement combination instead of
toTextFormControl.

• WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::inputMethodEvent):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/editing/Editor.cpp (modified) (2 diffs)
• WebCore/html/HTMLElement.cpp (modified) (1 diff)
• WebCore/html/HTMLTextFormControlElement.cpp (modified) (1 diff)
• WebCore/html/HTMLTextFormControlElement.h (modified) (1 diff)
• WebCore/rendering/RenderTextControl.cpp (modified) (2 diffs)
• WebCore/testing/Internals.cpp (modified) (1 diff)
• WebKit/qt/ChangeLog (modified) (1 diff)
• WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-18  Shinya Kawanaka  <shinyak@chromium.org>
+
+        Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement instead of toTextFormControl
+        https://bugs.webkit.org/show_bug.cgi?id=107089
+
+        Reviewed by Kent Tamura.
+
+        toTextFormControl(node) returns 0 if node is not HTMLTextFormControl. In recent coding convention,
+        we only have ASSERT and statc_cast in this kind of conversion function. So this code looks like
+        having a bad cast, though it does not.
+
+        In this patch, we convert toTextFromControl to isHTMLTextFormControlElement and toHTMLFormControlElement,
+        which aligns our coding convention.
+
+        No new tests, simple refactoring.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::selectionForCommand):
+        (WebCore::Editor::setBaseWritingDirection):
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::directionality):
+        * html/HTMLTextFormControlElement.cpp:
+        (WebCore::enclosingTextFormControl):
+        * html/HTMLTextFormControlElement.h:
+        (WebCore::isHTMLTextFormControlElement):
+        (WebCore):
+        (WebCore::toHTMLTextFormControlElement):
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::RenderTextControl):
+        (WebCore::RenderTextControl::layoutSpecialExcludedChild):
+        * testing/Internals.cpp:
+        (WebCore::Internals::visiblePlaceholder):
+
 2013-01-18  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/editing/Editor.cpp

@@ -111 +111 @@
     // then use the saved selection for that text control.
     HTMLTextFormControlElement* textFormControlOfSelectionStart = enclosingTextFormControl(selection.start());
-    HTMLTextFormControlElement* textFromControlOfTarget = toTextFormControl(event->target()->toNode());
+    HTMLTextFormControlElement* textFromControlOfTarget = isHTMLTextFormControlElement(event->target()->toNode()) ? toHTMLTextFormControlElement(event->target()->toNode()) : 0;
     if (textFromControlOfTarget && (selection.start().isNull() || textFromControlOfTarget != textFormControlOfSelectionStart)) {
         if (RefPtr<Range> range = textFromControlOfTarget->selection())
@@ -1295 +1295 @@
 {
     Node* focusedNode = frame()->document()->focusedNode();
-    if (toTextFormControl(focusedNode)) {
+    if (focusedNode && isHTMLTextFormControlElement(focusedNode)) {
         if (direction == NaturalWritingDirection)
             return;

trunk/Source/WebCore/html/HTMLElement.cpp

@@ -855 +855 @@
 TextDirection HTMLElement::directionality(Node** strongDirectionalityTextNode) const
 {
-    if (HTMLTextFormControlElement* textElement = toTextFormControl(const_cast<HTMLElement*>(this))) {
+    if (isHTMLTextFormControlElement(this)) {
+        HTMLTextFormControlElement* textElement = toHTMLTextFormControlElement(const_cast<HTMLElement*>(this));
         bool hasStrongDirectionality;
         Unicode::Direction textDirection = textElement->value().defaultWritingDirection(&hasStrongDirectionality);

trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp

@@ -646 +646 @@
     if (!container)
         return 0;
-    Node* ancestor = container->shadowHost();
-    return ancestor ? toTextFormControl(ancestor) : 0;
+    Element* ancestor = container->shadowHost();
+    return ancestor && isHTMLTextFormControlElement(ancestor) ? toHTMLTextFormControlElement(ancestor) : 0;
 }
 

trunk/Source/WebCore/html/HTMLTextFormControlElement.h

@@ -142 +142 @@
 };
 
-// This function returns 0 when node is an input element and not a text field.
-inline HTMLTextFormControlElement* toTextFormControl(Node* node)
+inline bool isHTMLTextFormControlElement(const Node* node)
 {
-    return (node && node->isElementNode() && static_cast<Element*>(node)->isTextFormControl()) ? static_cast<HTMLTextFormControlElement*>(node) : 0;
+    return node->isElementNode() && toElement(node)->isTextFormControl();
+}
+
+inline HTMLTextFormControlElement* toHTMLTextFormControlElement(Node* node)
+{
+    ASSERT(!node || isHTMLTextFormControlElement(node));
+    return static_cast<HTMLTextFormControlElement*>(node);
 }
 

trunk/Source/WebCore/rendering/RenderTextControl.cpp

@@ -40 +40 @@
     : RenderBlock(node)
 {
-    ASSERT(toTextFormControl(node));
+    ASSERT(isHTMLTextFormControlElement(node));
 }
 
@@ -304 +304 @@
 RenderObject* RenderTextControl::layoutSpecialExcludedChild(bool relayoutChildren)
 {
-    HTMLElement* placeholder = toTextFormControl(node())->placeholderElement();
+    HTMLElement* placeholder = toHTMLTextFormControlElement(node())->placeholderElement();
     RenderObject* placeholderRenderer = placeholder ? placeholder->renderer() : 0;
     if (!placeholderRenderer)

trunk/Source/WebCore/testing/Internals.cpp

@@ -686 +686 @@
 String Internals::visiblePlaceholder(Element* element)
 {
-    HTMLTextFormControlElement* textControl = toTextFormControl(element);
-    if (textControl && textControl->placeholderShouldBeVisible())
-        return textControl->placeholderElement()->textContent();
+    if (element && isHTMLTextFormControlElement(element)) {
+        if (toHTMLTextFormControlElement(element)->placeholderShouldBeVisible())
+            return toHTMLTextFormControlElement(element)->placeholderElement()->textContent();
+    }
+
     return String();
 }

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2013-01-18  Shinya Kawanaka  <shinyak@chromium.org>
+
+        Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement instead of toTextFormControl
+        https://bugs.webkit.org/show_bug.cgi?id=107089
+
+        Reviewed by Kent Tamura.
+
+        Updated code to use isHTMLTextFormControlElement and toHTMLTextFormControlElement combination instead of
+        toTextFormControl.
+
+        * WebCoreSupport/QWebPageAdapter.cpp:
+        (QWebPageAdapter::inputMethodEvent):
+
 2013-01-18  Seokju Kwon  <seokju.kwon@gmail.com>
 

trunk/Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp

@@ -677 +677 @@
             // A selection in the inputMethodEvent is always reflected in the visible text
             if (node) {
-                if (HTMLTextFormControlElement* textControl = toTextFormControl(node))
-                    textControl->setSelectionRange(qMin(a.start, (a.start + a.length)), qMax(a.start, (a.start + a.length)));
+                if (isHTMLTextFormControlElement(node))
+                    toHTMLTextFormControlElement(node)->setSelectionRange(qMin(a.start, (a.start + a.length)), qMax(a.start, (a.start + a.length)));
             }
 
@@ -699 +699 @@
         int cursorPos = frame->selection()->extent().offsetInContainerNode();
         int start = cursorPos + ev->replacementStart();
-        if (HTMLTextFormControlElement* textControl = toTextFormControl(node))
-            textControl->setSelectionRange(start, start + ev->replacementLength());
+        if (isHTMLTextFormControlElement(node))
+            toHTMLTextFormControlElement(node)->setSelectionRange(start, start + ev->replacementLength());
         // Commit regardless of whether commitString is empty, to get rid of selection.
         editor->confirmComposition(ev->commitString());