Changeset 140270 in webkit

Timestamp:

Jan 20, 2013 2:35:00 AM (11 years ago)

Author:

haraken@chromium.org

Message:

[V8] Create a persistent wrapper for Window.prototype and innerGlobalObject
​https://bugs.webkit.org/show_bug.cgi?id=107253

Reviewed by Adam Barth.

This is one of steps to avoid hitting an ASSERT()
that will be added in ​https://bugs.webkit.org/show_bug.cgi?id=107137 .
We should have a persistent wrapper for all DOM objects
and set a class id on the wrapper.

No tests. No change in behavior.

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-20  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Create a persistent wrapper for Window.prototype and innerGlobalObject
+        https://bugs.webkit.org/show_bug.cgi?id=107253
+
+        Reviewed by Adam Barth.
+
+        This is one of steps to avoid hitting an ASSERT()
+        that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 .
+        We should have a persistent wrapper for all DOM objects
+        and set a class id on the wrapper.
+
+        No tests. No change in behavior.
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::V8DOMWindowShell::installDOMWindow):
+
 2013-01-19  Philip Rogers  <pdr@google.com>
 

trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -318 +318 @@
     V8DOMWindow::installPerContextProperties(windowWrapper, window);
 
-    V8DOMWrapper::setNativeInfo(v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), &V8DOMWindow::info, window);
+    V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), m_isolate);
 
     // Install the windowWrapper as the prototype of the innerGlobalObject.
@@ -334 +334 @@
     //
     v8::Handle<v8::Object> innerGlobalObject = toInnerGlobalObject(m_context.get());
-    V8DOMWrapper::setNativeInfo(innerGlobalObject, &V8DOMWindow::info, window);
+    V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, innerGlobalObject, m_isolate);
     innerGlobalObject->SetPrototype(windowWrapper);
     V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, windowWrapper, m_isolate);