Changeset 140295 in webkit

Timestamp:

Jan 20, 2013 10:08:05 PM (11 years ago)

Author:

haraken@chromium.org

Message:

[V8] Remove custom V8ScriptProfileCustom::toV8()
​https://bugs.webkit.org/show_bug.cgi?id=107246

Reviewed by Adam Barth.

V8ScriptProfileCustom::toV8() needs not to be custom.
Furthermore, the current custom toV8() is wrong in that
it doesn't use a creationContext and it doesn't set a
wrapper class id. This is one of steps to avoiding
ASSERT()s that will be added in
​https://bugs.webkit.org/show_bug.cgi?id=107137 .

No tests. No change in behavior.

• UseV8.cmake:
• WebCore.gypi:
• bindings/v8/custom/V8ScriptProfileCustom.cpp: Removed.
• inspector/ScriptProfile.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• UseV8.cmake (modified) (1 diff)
• WebCore.gypi (modified) (1 diff)
• bindings/v8/custom/V8ScriptProfileCustom.cpp (deleted)
• inspector/ScriptProfile.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-20  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Remove custom V8ScriptProfileCustom::toV8()
+        https://bugs.webkit.org/show_bug.cgi?id=107246
+
+        Reviewed by Adam Barth.
+
+        V8ScriptProfileCustom::toV8() needs not to be custom.
+        Furthermore, the current custom toV8() is wrong in that
+        it doesn't use a creationContext and it doesn't set a
+        wrapper class id. This is one of steps to avoiding
+        ASSERT()s that will be added in
+        https://bugs.webkit.org/show_bug.cgi?id=107137 .
+
+        No tests. No change in behavior.
+
+        * UseV8.cmake:
+        * WebCore.gypi:
+        * bindings/v8/custom/V8ScriptProfileCustom.cpp: Removed.
+        * inspector/ScriptProfile.idl:
+
 2013-01-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/UseV8.cmake

@@ -179 +179 @@
 
         bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
-        bindings/v8/custom/V8ScriptProfileCustom.cpp
     )
 endif ()

trunk/Source/WebCore/WebCore.gypi

@@ -1386 +1386 @@
             'bindings/v8/custom/V8SVGLengthCustom.cpp',
             'bindings/v8/custom/V8SVGPathSegCustom.cpp',
-            'bindings/v8/custom/V8ScriptProfileCustom.cpp',
             'bindings/v8/custom/V8StorageCustom.cpp',
             'bindings/v8/custom/V8StyleSheetCustom.cpp',

trunk/Source/WebCore/inspector/ScriptProfile.idl

@@ -27 +27 @@
 [
     Conditional=JAVASCRIPT_DEBUGGER,
-    OmitConstructor,
-    V8CustomToJSObject,
-    V8NoWrapperCache
+    OmitConstructor
 ] interface ScriptProfile {
     readonly attribute DOMString title;