Changeset 140325 in webkit

Timestamp:

Jan 21, 2013 5:34:11 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Gtk] [Cairo] Memory leak when is WebView destroy.
​https://bugs.webkit.org/show_bug.cgi?id=107112

Patch by Oleg Smirnov <​oleg.smirnov@lge.com> on 2013-01-21
Reviewed by Martin Robinson.

Make createSurfaceForBackingStore return a smart pointer in all supported
build configurations to avoid a memory leak.

No new tests. There is memory leak only.

• platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::createSurfaceForBackingStore):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cairo/WidgetBackingStoreCairo.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-21  Oleg Smirnov  <oleg.smirnov@lge.com>
+
+        [Gtk] [Cairo] Memory leak when is WebView destroy.
+        https://bugs.webkit.org/show_bug.cgi?id=107112
+
+        Reviewed by Martin Robinson.
+
+        Make createSurfaceForBackingStore return a smart pointer in all supported
+        build configurations to avoid a memory leak.
+        
+        No new tests. There is memory leak only.
+
+        * platform/cairo/WidgetBackingStoreCairo.cpp:
+        (WebCore::createSurfaceForBackingStore):
+
 2013-01-21  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp

@@ -34 +34 @@
 {
 #if PLATFORM(GTK)
-    return gdk_window_create_similar_surface(gtk_widget_get_window(widget),
-                                             CAIRO_CONTENT_COLOR_ALPHA,
-                                             size.width(), size.height());
+    return adoptRef(gdk_window_create_similar_surface(gtk_widget_get_window(widget), CAIRO_CONTENT_COLOR_ALPHA, size.width(), size.height()));
 #else
     UNUSED_PARAM(widget);