Changeset 140326 in webkit

Timestamp:

Jan 21, 2013 5:40:06 AM (11 years ago)

Author:

jocelyn.turcotte@digia.com

Message:

[Qt] Update the documentation about the storage of inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=106777

Reviewed by Allan Sandfeld Jensen.

Since r76770, QSettings isn't queried anymore to persist inspector
settings like whether or not the debugger is enabled by default.
It still seems to be used for the default attach height.

Update the documentation accordingly.

• WidgetApi/qwebinspector.cpp:

Location:

trunk/Source/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WidgetApi/qwebinspector.cpp (modified) (1 diff)

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2013-01-21  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
+
+        [Qt] Update the documentation about the storage of inspector settings
+        https://bugs.webkit.org/show_bug.cgi?id=106777
+
+        Reviewed by Allan Sandfeld Jensen.
+
+        Since r76770, QSettings isn't queried anymore to persist inspector
+        settings like whether or not the debugger is enabled by default.
+        It still seems to be used for the default attach height.
+
+        Update the documentation accordingly.
+
+        * WidgetApi/qwebinspector.cpp:
+
 2013-01-21  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 

trunk/Source/WebKit/qt/WidgetApi/qwebinspector.cpp

@@ -67 +67 @@
     The inspector allows the user to configure some options through its
     user interface (e.g. the resource tracking "Always enable" option).
-    These settings will be persisted automatically by QtWebKit only if
-    your application previously called QCoreApplication::setOrganizationName()
-    and QCoreApplication::setApplicationName().
-    See QSettings's default constructor documentation for an explanation
-    of why this is necessary.
+    The inspector UI is itself a web page and is using HTML local storage
+    to persist those settings.
+    Since the internal QWebPage used by the inspector isn't exposed in the API,
+    the only way to enable those settings to be persisted is currently to enable
+    local storage globally through QWebSettings::globalSettings().
+
+    \sa QWebSettings::localStoragePath(), QWebSettings::LocalStorageEnabled
 */