Changeset 140344 in webkit
- Timestamp:
- Jan 21, 2013 10:44:19 AM (11 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r140337 r140344 1 2013-01-21 Christophe Dumez <christophe.dumez@intel.com> 2 3 Regression(r140262): Causes a lot of flakiness 4 https://bugs.webkit.org/show_bug.cgi?id=107454 5 6 Reviewed by Alexey Proskuryakov. 7 8 r140262 introduced a lot of flakiness due to fixed layout mode 9 not getting disabled on the view after being enabled for 10 specific test cases. This patch makes sure fixed layout mode 11 properly gets reset in WebKitTestRunner to avoid flakiness. 12 13 * WebKitTestRunner/TestInvocation.cpp: 14 (WTR::updateLayoutType): 15 1 16 2013-01-21 Gustavo Noronha Silva <gns@gnome.org> 2 17 -
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
r140262 r140344 193 193 static void updateLayoutType(const char* pathOrURL) 194 194 { 195 bool useFixedLayout = shouldUseFixedLayout(pathOrURL);196 if (!useFixedLayout)197 return;198 199 195 WKRetainPtr<WKMutableDictionaryRef> viewOptions = adoptWK(WKMutableDictionaryCreate()); 200 196 WKRetainPtr<WKStringRef> useFixedLayoutKey = adoptWK(WKStringCreateWithUTF8CString("UseFixedLayout")); 201 WKRetainPtr<WKBooleanRef> useFixedLayoutValue = adoptWK(WKBooleanCreate( useFixedLayout));197 WKRetainPtr<WKBooleanRef> useFixedLayoutValue = adoptWK(WKBooleanCreate(shouldUseFixedLayout(pathOrURL))); 202 198 WKDictionaryAddItem(viewOptions.get(), useFixedLayoutKey.get(), useFixedLayoutValue.get()); 203 199
Note: See TracChangeset
for help on using the changeset viewer.