Changeset 140351 in webkit

Timestamp:

Jan 21, 2013 12:51:19 PM (11 years ago)

Author:

andersca@apple.com

Message:

Don't null out the IPC connection in ChildProcess:terminate
​https://bugs.webkit.org/show_bug.cgi?id=107469
<rdar://problem/13015294>

Reviewed by Dan Bernstein.

We already invalidate the connection, and Connection::sendMessage checks if a connection
is valid and bails if it isn't, so the only thing that nulling out the connection here does
is that it would force us to add random connection null checks everywhere.

• Shared/ChildProcess.cpp:

(WebKit::ChildProcess::terminate):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/ChildProcess.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-01-21  Anders Carlsson  <andersca@apple.com>
+
+        Don't null out the IPC connection in ChildProcess:terminate
+        https://bugs.webkit.org/show_bug.cgi?id=107469
+        <rdar://problem/13015294>
+
+        Reviewed by Dan Bernstein.
+
+        We already invalidate the connection, and Connection::sendMessage checks if a connection
+        is valid and bails if it isn't, so the only thing that nulling out the connection here does
+        is that it would force us to add random connection null checks everywhere.
+
+        * Shared/ChildProcess.cpp:
+        (WebKit::ChildProcess::terminate):
+
 2013-01-21  Joone Hur  <joone.hur@intel.com>
 

trunk/Source/WebKit2/Shared/ChildProcess.cpp

@@ -143 +143 @@
 {
     m_connection->invalidate();
-    m_connection = nullptr;
 
     RunLoop::main()->stop();