Changeset 140372 in webkit

Timestamp:

Jan 21, 2013 5:04:34 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
​https://bugs.webkit.org/show_bug.cgi?id=107363

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-01-21
Reviewed by Benjamin Poulain.

Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.

This prevents printing warnings about "Localized string not found" in
the console and fixes Web inspector related failing tests on the bots.

• WebProcess/WebPage/efl/WebInspectorEfl.cpp:

(WebKit::WebInspector::localizedStringsURL):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/efl/WebInspectorEfl.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-01-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
+
+        [EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
+        https://bugs.webkit.org/show_bug.cgi?id=107363
+
+        Reviewed by Benjamin Poulain.
+
+        Implement WebInspector::localizedStringsURL() method to return the
+        file URL of the localizedStrings.js.
+
+        This prevents printing warnings about "Localized string not found" in
+        the console and fixes Web inspector related failing tests on the bots.
+
+        * WebProcess/WebPage/efl/WebInspectorEfl.cpp:
+        (WebKit::WebInspector::localizedStringsURL):
+
 2013-01-21  Kiran Muppala  <cmuppala@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp

@@ -29 +29 @@
 #if ENABLE(INSPECTOR)
 
-#include <WebCore/NotImplemented.h>
+#include <WebCore/EflInspectorUtilities.h>
 #include <wtf/text/WTFString.h>
 
@@ -36 +36 @@
 String WebInspector::localizedStringsURL() const
 {
-    notImplemented();
-    return String();
+    return "file://" + WebCore::inspectorResourcePath() + "/localizedStrings.js";
 }